Page MenuHomeFreeBSD
Differential D54326

kern: document no-op handling of syscall number 0 during deregistration
ClosedPublic
Actions

Authored by go4av05.pvtx_gmail.com on Sat, Dec 20, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 11, 1:09 AM
Unknown Object (File)
Thu, Jan 8, 1:38 AM
Unknown Object (File)
Wed, Jan 7, 7:49 PM
Unknown Object (File)
Wed, Jan 7, 3:37 AM
Unknown Object (File)
Tue, Jan 6, 4:27 AM
Unknown Object (File)
Sat, Jan 3, 2:37 PM
Unknown Object (File)
Sat, Jan 3, 7:24 AM
Unknown Object (File)
Sat, Jan 3, 6:16 AM
View All 18 Files
Subscribers
imp
ngie
olce

Details

Reviewers
ngie
adrian
Commits
rGf384784289db: kern_syscall_deregister: document syscall 0 no-op logic
Summary

Clarify why kern_syscall_deregister() treats syscall number 0 as a no-op.

Syscall number 0 is reserved and is not dynamically registered, so
returning success simplifies module unload paths.

No functional change intended.

Test Plan

Not applicable (comment-only change).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

go4av05.pvtx_gmail.com created this revision.Sat, Dec 20, 5:48 PM
Herald added subscribers: olce, imp. · View Herald TranscriptSat, Dec 20, 5:48 PM
go4av05.pvtx_gmail.com requested review of this revision.Sat, Dec 20, 5:48 PM
ngie added a subscriber: ngie.Sun, Dec 28, 10:20 PM
ngie added inline comments.
sys/kern/kern_syscalls.c
165–168

At first blush the comment content looks great!

Please indent all of the lines following the initial opening block to the same indentation (so, an extra space before the * on lines 166-168).

Also, I'm not sure how you contributed the patch, but it should be done following git arc create ..., etc. I would have liked to provide a suggested fix, but that isn't possible in the UI currently (I don't know if it's related to the base revision, but it might be).

ngie mentioned this in D54324: kern: document rationale for PRIV_REBOOT usage in kexec_load.Sun, Dec 28, 10:23 PM
go4av05.pvtx_gmail.com updated this revision to Diff 168689.Mon, Dec 29, 6:56 AM
go4av05.pvtx_gmail.com added a reviewer: ngie.

Enji Cooper asked to fix * alignment.
Created a patch via git diff and uploaded the patch on the phabricator website dashboard.
Did not use arc.

No Functional change intended.

ngie added inline comments.Mon, Dec 29, 7:57 PM
sys/kern/kern_syscalls.c
165

I'm sorry if I wasn't explicit about this part in my previous comment, but this also needs to be hard-tab indented per style(9).

go4av05.pvtx_gmail.com mentioned this in D54391: Clarify TAI offset validation in kern_ntptime.Thu, Jan 1, 11:20 AM
adrian accepted this revision.Fri, Jan 2, 7:12 AM
This revision is now accepted and ready to land.Fri, Jan 2, 7:12 AM
ngie accepted this revision.Fri, Jan 2, 7:28 PM

I'll take up the patch and fix up the whitespace bug since it's a trivial change which adds helpful documentation.

In general, please submit patches in the future that follow style(9) so they can be accepted more frictionlessly.

Closed by commit rGf384784289db: kern_syscall_deregister: document syscall 0 no-op logic (authored by go4av05.pvtx_gmail.com, committed by ngie). · Explain WhyTue, Jan 6, 7:49 AM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGf384784289db: kern_syscall_deregister: document syscall 0 no-op logic.

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines

Diff 168689

View Options

sys/kern/kern_syscalls.c

Loading...