Page MenuHomeFreeBSD
Differential D54391

Clarify TAI offset validation in kern_ntptime
Needs ReviewPublic
Actions

Authored by go4av05.pvtx_gmail.com on Mon, Dec 29, 6:27 AM.
Tags
None
Referenced Files
F141230159: D54391.id168819.diff
Fri, Jan 2, 5:52 PM
F141211395: D54391.id168819.diff
Fri, Jan 2, 10:53 AM
Unknown Object (File)
Wed, Dec 31, 3:21 PM
Unknown Object (File)
Wed, Dec 31, 1:08 AM
Unknown Object (File)
Mon, Dec 29, 5:57 PM
Unknown Object (File)
Mon, Dec 29, 12:55 PM
Subscribers
adrian
imp
olce

Details

Reviewers
imp
Summary

Clarify that the MOD_TAI check enforces a positive UTC–TAI offset,
per review feedback.

Test Plan

Not applicable (comment-only change).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69553
Build 66436: arc lint + arc unit

Event Timeline

go4av05.pvtx_gmail.com created this revision.Mon, Dec 29, 6:27 AM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, Dec 29, 6:27 AM
go4av05.pvtx_gmail.com requested review of this revision.Mon, Dec 29, 6:27 AM
Harbormaster completed remote builds in B69497: Diff 168687.Mon, Dec 29, 6:27 AM
go4av05.pvtx_gmail.com retitled this revision from # Enter a commit message. Clarify TAI offset validation in kern_ntptime to Clarify TAI offset validation in kern_ntptime.Mon, Dec 29, 6:39 AM
go4av05.pvtx_gmail.com added a parent revision: D54384: kern_ntptime: document handling of non-positive time constant.Mon, Dec 29, 7:01 AM
imp accepted this revision.Mon, Dec 29, 7:44 AM
This revision is now accepted and ready to land.Mon, Dec 29, 7:44 AM
go4av05.pvtx_gmail.com updated this revision to Diff 168819.Thu, Jan 1, 11:20 AM
This comment was removed by go4av05.pvtx_gmail.com.
This revision now requires review to proceed.Thu, Jan 1, 11:20 AM
Harbormaster completed remote builds in B69553: Diff 168819.Thu, Jan 1, 11:20 AM
adrian added a subscriber: adrian.Fri, Jan 2, 7:15 AM
adrian added inline comments.
sys/kern/kern_kexec.c
345

Does this belong in this diff? It looks like it's in D54324

sys/kern/kern_syscalls.c
166

Same with this, this looks like D54326?

Revision Contents
Changeset List

PathSize
sys/
kern/
14 lines
2 lines
9 lines

Diff 168819

View Options

sys/kern/kern_kexec.c

Loading...
View Options

sys/kern/kern_ntptime.c

Loading...
View Options

sys/kern/kern_syscalls.c

Loading...