kern: document rationale for PRIV_REBOOT usage in kexec_load
Needs ReviewPublic
Actions

Authored by go4av05.pvtx_gmail.com on Dec 20 2025, 3:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 20, 8:58 AM

	Unknown Object (File)
	Sat, Jun 13, 12:39 PM

	Unknown Object (File)
	May 20 2026, 8:27 PM

	Unknown Object (File)
	May 19 2026, 5:21 AM

	Unknown Object (File)
	May 19 2026, 2:41 AM

	Unknown Object (File)
	May 19 2026, 12:47 AM

	Unknown Object (File)
	May 16 2026, 10:15 AM

	Unknown Object (File)
	May 16 2026, 1:32 AM

Subscribers

Details

Reviewers

imp

Summary

Document why kexec_load() currently relies on PRIV_REBOOT for access
control, noting that loading a new kernel image is more powerful than
a traditional reboot and may warrant finer-grained privileges in the
future.

No functional change intended.

Test Plan

Not applicable (comment-only change).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

go4av05.pvtx_gmail.com created this revision.Dec 20 2025, 3:57 AM

Herald added subscribers: olce, imp. · View Herald TranscriptDec 20 2025, 3:57 AM

go4av05.pvtx_gmail.com requested review of this revision.Dec 20 2025, 3:57 AM

imp accepted this revision.Dec 20 2025, 6:00 AM

This revision is now accepted and ready to land.Dec 20 2025, 6:00 AM

ngie added a subscriber: ngie.Dec 28 2025, 10:23 PM

ngie added inline comments.

sys/kern/kern_kexec.c
344–356	My feedback in https://reviews.freebsd.org/D54326 applies here as well.

Enji Cooper asked to fix * alignment.
No Functional change intended.

This revision now requires review to proceed.Dec 29 2025, 6:51 AM

go4av05.pvtx_gmail.com mentioned this in D54391: Clarify TAI offset validation in kern_ntptime.Jan 1 2026, 11:20 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_kexec.c

14 lines

Diff 168688

View Options

kern: document rationale for PRIV_REBOOT usage in kexec_loadNeeds ReviewPublicActions