kern: document rationale for PRIV_REBOOT usage in kexec_load
Needs ReviewPublic
Actions

Authored by go4av05.pvtx_gmail.com on Sat, Dec 20, 3:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 29, 5:09 PM

	Unknown Object (File)
	Mon, Dec 29, 6:45 AM

	Unknown Object (File)
	Fri, Dec 26, 5:06 AM

	Unknown Object (File)
	Thu, Dec 25, 11:40 PM

	Unknown Object (File)
	Thu, Dec 25, 10:32 PM

	Unknown Object (File)
	Tue, Dec 23, 7:26 AM

	Unknown Object (File)
	Mon, Dec 22, 12:11 AM

	Unknown Object (File)
	Sun, Dec 21, 9:10 AM

Subscribers

Details

Reviewers

imp

Summary

Document why kexec_load() currently relies on PRIV_REBOOT for access
control, noting that loading a new kernel image is more powerful than
a traditional reboot and may warrant finer-grained privileges in the
future.

No functional change intended.

Test Plan

Not applicable (comment-only change).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

go4av05.pvtx_gmail.com created this revision.Sat, Dec 20, 3:57 AM

Herald added subscribers: olce, imp. · View Herald TranscriptSat, Dec 20, 3:57 AM

go4av05.pvtx_gmail.com requested review of this revision.Sat, Dec 20, 3:57 AM

imp accepted this revision.Sat, Dec 20, 6:00 AM

This revision is now accepted and ready to land.Sat, Dec 20, 6:00 AM

ngie added a subscriber: ngie.Sun, Dec 28, 10:23 PM

ngie added inline comments.

sys/kern/kern_kexec.c
344–356	My feedback in https://reviews.freebsd.org/D54326 applies here as well.

Enji Cooper asked to fix * alignment.
No Functional change intended.

This revision now requires review to proceed.Mon, Dec 29, 6:51 AM

go4av05.pvtx_gmail.com mentioned this in D54391: Clarify TAI offset validation in kern_ntptime.Thu, Jan 1, 11:20 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_kexec.c

14 lines

Diff 168688

View Options

kern: document rationale for PRIV_REBOOT usage in kexec_loadNeeds ReviewPublicActions