Differential D54374
release.sh: allow GITROOT, etc, to be overridden Authored by ngie on Dec 26 2025, 5:48 PM. Tags None Referenced Files
Details
release(7) claims that the various variables, e.g., GITROOT, etc, can This change allows the following variables to be overridden in config This change allowed me to do the following in a config file: SRCCONF="$(dirname "$0")/src.conf" GITROOT="file:///home/ngie/git/" GITSRC="freebsd-src" GITPORTS="freebsd-ports"
Diff Detail
Event TimelineComment Actions Hmm, I thought the way this worked was that env_setup set defaults and then the config file was sourced to override those values. Comment Actions There's no way to just redefine some of the values in a custom conf file (the conf definition of env_setup would shadow the release.sh provided definition), so instead you end up having to fork the entire function to tweak the behavior for a few variables. It seems like env_setup should be named default_env_setup and env_setup should be a no-op function that allows others to override the values. I would be game for doing that instead since that would be a lot cleaner/easier to document in release(7). Comment Actions Sorry, I completely forgot about this patch. Thanks for the ping. Looking at the release.sh code, env_setup is called first from main and really should be called env_setup_default, and then the configuration provided via -c RELEASECONF is sourced. So I really don't see what needs to be changed.
You know that should be SRC_CONF right? Comment Actions Yeah. I can't reproduce the issue I ran into originally, so I'm going to drop this change and work on other potential improvements instead.
I probably used SRC_CONF when running release.sh, but used SRCCONF in the testing section out of habit. |