Page MenuHomeFreeBSD
Differential D54359

sound: Add kqueue support to MIDI
Needs ReviewPublic
Actions

Authored by meka_tilda.center on Thu, Dec 25, 12:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 8, 3:37 AM
Unknown Object (File)
Thu, Jan 8, 3:33 AM
Unknown Object (File)
Sun, Jan 4, 11:32 PM
Unknown Object (File)
Wed, Dec 31, 9:59 AM
Unknown Object (File)
Wed, Dec 31, 3:53 AM
Unknown Object (File)
Tue, Dec 30, 7:42 PM
Unknown Object (File)
Mon, Dec 29, 2:10 PM
Unknown Object (File)
Sat, Dec 27, 12:22 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
christos
Summary

Recently sound(4) got support for kqueue, so this is natural extension.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

meka_tilda.center created this revision.Thu, Dec 25, 12:39 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Dec 25, 12:39 AM
meka_tilda.center requested review of this revision.Thu, Dec 25, 12:39 AM
meka_tilda.center added inline comments.
sys/dev/sound/midi/midi.c
769

I didn't find anything like CHN_F_DEAD in dsp.c so what do I need to check?

meka_tilda.center updated this revision to Diff 168590.Fri, Dec 26, 1:32 AM

Use lock instead of qlock which will be removed in the future.

meka_tilda.center updated this revision to Diff 168645.Sat, Dec 27, 6:37 PM

As midi_destroy will be removed, adapt this patch for that.

christos added a comment.Fri, Jan 2, 3:52 PM

There are a lot of MIDI patches in review that simplify the code, so this won't apply. I can rewrite it on top of them if you want.

christos added a comment.Fri, Jan 2, 3:52 PM

Also I suppose you know this code does not work for USB MIDI, at the moment. I will eventually make USB MIDI attach to it, but currently this only works for physical MIDI.

meka_tilda.center added a comment.Fri, Jan 2, 3:54 PM
In D54359#1244356, @christos wrote:

There are a lot of MIDI patches in review that simplify the code, so this won't apply. I can rewrite it on top of them if you want.

I expected to rebase this patch as you merge other patches, so feel free to leave this patch for later and I'll rebase it.

meka_tilda.center added a comment.Fri, Jan 2, 3:55 PM
In D54359#1244357, @christos wrote:

Also I suppose you know this code does not work for USB MIDI, at the moment. I will eventually make USB MIDI attach to it, but currently this only works for physical MIDI.

But I tested it only with USB MIDI. Anyway, why do you think it will not work? What am I missing?

christos mentioned this in D54360: sound examples: Add MIDI kqueue example.Fri, Jan 2, 3:55 PM
In D54359#1244359, @meka_tilda.center wrote:

Anyway, why do you think it will not work?

Because this code currently does not run with USB MIDI at all. All the USB MIDI code in snd_uaudio(4).

christos added a comment.Fri, Jan 2, 5:06 PM

You can rebase it already. I just committed the patches.

meka_tilda.center updated this revision to Diff 169439.Sat, Jan 10, 3:21 AM

I rebased this patch, but the problem is that I don't have the hardware to test it. I'll try to find cheap PCIe card to test this patch.

christos added a comment.Sat, Jan 10, 11:25 AM

For testing you can use snd_dummy(4), I added some basic MIDI support, although you might need to make it more functional because it basically does more or less nothing currently.

snd_midi has a hiwat (high watermark) field which is used in midi_poll() as well. Also please provide a diff with full context.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
70 lines

Diff 168590

View Options

sys/dev/sound/midi/midi.c

Loading...