Page MenuHomeFreeBSD

crypto: avoid warnings about too-long initializer strings
ClosedPublic

Authored by dim on Dec 26 2025, 12:14 AM.
Tags
None
Referenced Files
F168224418: D54364.id168771.diff
Thu, Aug 27, 12:49 AM
Unknown Object (File)
Sat, Aug 22, 12:11 AM
Unknown Object (File)
Mon, Aug 17, 6:00 PM
Unknown Object (File)
Sun, Aug 16, 8:56 PM
Unknown Object (File)
Sun, Aug 16, 8:24 PM
Unknown Object (File)
Sat, Aug 15, 8:44 PM
Unknown Object (File)
Sat, Aug 15, 7:46 PM
Unknown Object (File)
Tue, Aug 11, 11:00 PM
Subscribers

Details

Summary

Mark sigma and tau as __non_string, to avoid warnings from
clang 21 similar to:

sys/crypto/chacha20/chacha.c:53:31: error: initializer-string for character array is too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
   53 | static const char sigma[16] = "expand 32-byte k";
      |                               ^~~~~~~~~~~~~~~~~~
sys/crypto/chacha20/chacha.c:54:29: error: initializer-string for character array is too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
   54 | static const char tau[16] = "expand 16-byte k";
      |                             ^~~~~~~~~~~~~~~~~~

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 69469
Build 66352: arc lint + arc unit

Event Timeline

dim requested review of this revision.Dec 26 2025, 12:14 AM

Fix double word in commit message.

This revision is now accepted and ready to land.Dec 29 2025, 2:37 PM