acpi: Use M_WAITOK in acpi_register_ioctl
AcceptedPublic
Actions

Authored by jhb on Fri, Dec 19, 3:26 PM.

Tags

None

Referenced Files

	F140298054: D54312.diff
	Mon, Dec 22, 10:42 AM

	F140248096: D54312.diff
	Sun, Dec 21, 8:58 PM

	Unknown Object (File)
	Sun, Dec 21, 5:01 AM

	Unknown Object (File)
	Fri, Dec 19, 6:03 PM

	Unknown Object (File)
	Fri, Dec 19, 5:56 PM

	Unknown Object (File)
	Fri, Dec 19, 5:43 PM

	Unknown Object (File)
	Fri, Dec 19, 5:36 PM

	Unknown Object (File)
	Fri, Dec 19, 5:34 PM

Subscribers

None

Details

Reviewers

imp
jkim

Summary

This function is only called from device attach routines which can
sleep.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69400
Build 66283: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Fri, Dec 19, 3:26 PM

jhb created this revision.

jhb added a parent revision: D54311: acpi: Reject duplicate handlers for ioctl commands.

jhb added a child revision: D54313: acpi: Statically initialize acpi_ioctl_hooks.

Harbormaster completed remote builds in B69400: Diff 168418.Fri, Dec 19, 3:26 PM

imp accepted this revision.Fri, Dec 19, 4:16 PM

This revision is now accepted and ready to land.Fri, Dec 19, 4:16 PM

BTW, I've thought about adding an acpi_unregister_ioctl_all or the like that just takes the fn argument and unregisters all commands that use the same function. That would be a nicer way to handle unloading of a module that registers multiple handlers.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi.c

3 lines

Diff 168418

View Options

acpi: Use M_WAITOK in acpi_register_ioctlAcceptedPublicActions