Page MenuHomeFreeBSD
Differential D54309

acpi: Free ivars in bus_child_deleted method
ClosedPublic
Actions

Authored by jhb on Dec 19 2025, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 14, 4:40 AM
Unknown Object (File)
Mon, Jan 12, 4:10 PM
Unknown Object (File)
Mon, Jan 12, 4:10 PM
Unknown Object (File)
Mon, Jan 12, 3:47 PM
Unknown Object (File)
Sat, Jan 10, 4:50 AM
Unknown Object (File)
Sat, Jan 10, 4:42 AM
Unknown Object (File)
Fri, Jan 9, 7:07 PM
Unknown Object (File)
Wed, Jan 7, 10:31 PM
View All 21 Files
Subscribers
None

Details

Reviewers
imp
jkim
Commits
rG5b39245ab6f3: acpi: Free ivars in bus_child_deleted method
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69397
Build 66280: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Dec 19 2025, 3:25 PM
jhb created this revision.
jhb added a parent revision: D54308: acpidump: Extend the decoding of entries in the EINJ and ERST tables.
jhb added a child revision: D54310: acpi_apei: Remove the hest member from the softc.
Harbormaster completed remote builds in B69397: Diff 168415.Dec 19 2025, 3:26 PM
imp accepted this revision.Dec 19 2025, 4:15 PM
imp added inline comments.
sys/dev/acpica/acpi.c
1119

This makes me wonder if there's some way we can detect leaks like this...
The change is, of course, spot on.

This revision is now accepted and ready to land.Dec 19 2025, 4:15 PM
jhb added inline comments.Dec 19 2025, 6:17 PM
sys/dev/acpica/acpi.c
1119

Maybe MSAN? The thing is, ACPI devices are rarely deleted, so it would be hard to trigger a leak I think. I only noticed this by code reading.

Closed by commit rG5b39245ab6f3: acpi: Free ivars in bus_child_deleted method (authored by jhb). · Explain WhyFri, Dec 26, 3:44 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG5b39245ab6f3: acpi: Free ivars in bus_child_deleted method.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
1 line

Diff 168415

View Options

sys/dev/acpica/acpi.c

Loading...