Page MenuHomeFreeBSD
Differential D54290

telnet: Remove usage of ALIGN
ClosedPublic
Actions

Authored by markj on Thu, Dec 18, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 20, 5:31 PM
Unknown Object (File)
Sat, Dec 20, 10:21 AM
Unknown Object (File)
Fri, Dec 19, 11:37 AM
Unknown Object (File)
Fri, Dec 19, 3:02 AM
Unknown Object (File)
Fri, Dec 19, 2:41 AM
Unknown Object (File)
Thu, Dec 18, 6:16 PM
Subscribers
imp

Details

Reviewers
brooks
Commits
rG3a4275a5f1f5: telnet: Remove usage of ALIGN
Summary

gcc doesn't like ALIGN() being applied to an array type. Just use
__aligned instead.

Fixes: 80203a27e964 ("Add sys/_align.h replacing machine/_align.h")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69375
Build 66258: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Dec 18, 5:50 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Dec 18, 5:50 PM
markj requested review of this revision.Thu, Dec 18, 5:50 PM
Harbormaster completed remote builds in B69375: Diff 168331.Thu, Dec 18, 5:50 PM
brooks accepted this revision.Mon, Dec 22, 10:10 AM
brooks added inline comments.
contrib/telnet/telnet/commands.c
2851

At least I think the XXX is probably referring to the evil use of ALIGN?

This revision is now accepted and ready to land.Mon, Dec 22, 10:10 AM
markj added inline comments.Mon, Dec 22, 3:18 PM
contrib/telnet/telnet/commands.c
2851

I had thought so too, but it predates it, see commit c847fdb1f93a7.

Closed by commit rG3a4275a5f1f5: telnet: Remove usage of ALIGN (authored by markj). · Explain WhyMon, Dec 22, 3:51 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG3a4275a5f1f5: telnet: Remove usage of ALIGN.

Revision Contents
Changeset List

PathSize
contrib/
telnet/
telnet/
4 lines

Diff 168331

View Options

contrib/telnet/telnet/commands.c

Loading...