df: ceil() the percentage value
Needs ReviewPublic
Actions

Authored by jlduran on Wed, Dec 17, 4:51 AM.

Details

Reviewers: None

Summary

The percentage value shall be expressed as a positive integer, with any
fractional result causing it to be rounded [up] to the next highest
integer.

https://pubs.opengroup.org/onlinepubs/9799919799/utilities/df.html

Use a hand-rolled ceil() equivalent (as long as it doesn't overflow), to
avoid using math.h.

Fix the tests accordingly, they now match the percentage values on
NetBSD.

Also, use the same rounding method for the calculation of used inodes.

Test Plan

$ kyua test
t_df:hflag  ->  passed  [0.009s]
t_df:normal  ->  passed  [0.008s]

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69325
Build 66208: arc lint + arc unit

Event Timeline

jlduran created this revision.Wed, Dec 17, 4:51 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 17, 4:51 AM

jlduran requested review of this revision.Wed, Dec 17, 4:51 AM

Harbormaster completed remote builds in B69325: Diff 168244.Wed, Dec 17, 4:51 AM

jlduran added a child revision: D54265: df: Fix the header when using the -P option.Wed, Dec 17, 4:52 AM

jlduran added a parent revision: D54016: df: Import tests from NetBSD.Wed, Dec 17, 5:01 AM

jlduran edited the summary of this revision. (Show Details)Wed, Dec 17, 5:36 AM

jlduran edited the test plan for this revision. (Show Details)

Round up the used inodes percentage as well. Although not required by POSIX, it would be odd to just have one percentage rounded up.

Revision Contents
Changeset List

Path

Size

bin/

df/

df.c

7 lines

tests/

t_df.sh

80 lines

Diff 168244

View Options

bin/df/df.c