libc: add strdupa(3) and strndupa(3)
ClosedPublic
Actions

Authored by kib on Thu, Dec 4, 12:53 AM.

Details

Reviewers

markj
emaste

Commits

rG98b7cca0186d: libc/string: put source files list one item per line
rGa98e5d785001: libc/string: add strdupa(3) and strndupa(3)

Summary

libc/string: put source files list one item per line


libc/string: add strdupa(3) and strndupa(3)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Thu, Dec 4, 12:53 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Dec 4, 12:53 AM

kib requested review of this revision.Thu, Dec 4, 12:53 AM

ziaee added inline comments.Thu, Dec 4, 1:41 AM

lib/libc/string/strdupa.c
2	This hyphen was for a parser Warner abandoned.
lib/libc/string/strndupa.c
4	Should we still SPDX tag this? It's ISC.

kib marked 2 inline comments as done.Thu, Dec 4, 3:18 AM

kib added inline comments.

lib/libc/string/strdupa.c
2	The two C files added are verbatim copy of the source files without 'a'. I kept the licenses blocks in both of them intact, since the change made in code is minuscule. I do not want to edit anything in there for the purpose of the commit. Afterwards, you can edit it as you see fit.

markj added inline comments.Thu, Dec 4, 2:16 PM

lib/libc/string/strdup.3
109	and strndupa(), no?

strndupa is from glibc as well

markj accepted this revision.Fri, Dec 5, 1:47 PM

This revision is now accepted and ready to land.Fri, Dec 5, 1:47 PM

This cannot work, alloca result is only valid for the duration of the current frame.
The functions can be moved to string.h as __always_inline, but I suspect that this would cause compat issues with weird compilers.

It seems that the only option is to define the extension macros together with the use of __builtin_alloca().

Switch to macros.

This revision now requires review to proceed.Fri, Dec 5, 9:45 PM

kib edited the summary of this revision. (Show Details)Fri, Dec 5, 9:46 PM

markj accepted this revision.Mon, Dec 8, 2:27 PM

This revision is now accepted and ready to land.Mon, Dec 8, 2:27 PM

Closed by commit rGa98e5d785001: libc/string: add strdupa(3) and strndupa(3) (authored by kib). · Explain WhyTue, Dec 9, 12:21 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGa98e5d785001: libc/string: add strdupa(3) and strndupa(3).

kib added a commit: rG98b7cca0186d: libc/string: put source files list one item per line.