sys/_types.h: avoid use of __has_feature()
ClosedPublic
Actions

Authored by brooks on Dec 1 2025, 10:59 AM.

Details

Reviewers

kib
des
imp
emaste

Group Reviewers

cheri

Commits

rG0a64d16cef17: sys/_types.h: avoid use of __has_feature()

Summary

Only fairly recent GCC versions support and sys/_types.h must work with
quite old compilers and without sys/cdef.h being included. The prior
workaround works fine, but we can have the same effect with compiler
macro definitions.

This reverts commit 029a09f18032353a9ae874590b879322efc6e53a
This reverts commit 19728f31ae421f40e2b0b0c775f4eedd7f927be0

Effort: CHERI upstreaming
Fixes: 85ab981a8e4e ("sys/_types.h: define fallback __(u)intcap_t")
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68953
Build 65836: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 1 2025, 10:59 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 1 2025, 10:59 AM

brooks requested review of this revision.Dec 1 2025, 10:59 AM

Harbormaster completed remote builds in B68953: Diff 167356.Dec 1 2025, 10:59 AM

brooks added inline comments.Dec 1 2025, 11:02 AM

sys/sys/_types.h
164	The most optimal gate would probably be `!defined(__INTCAP_TYPE__)` since it's a fundamental type provided by the compiler, but we seem to have forgotten to define that macro. I've filed a bug report on that lack https://github.com/CTSRD-CHERI/llvm-project/issues/796