Page MenuHomeFreeBSD

aq(4): Fix VLAN tag test
ClosedPublic

Authored by emaste on Nov 20 2025, 2:27 AM.
Tags
None
Referenced Files
F142155085: D53836.id167318.diff
Fri, Jan 16, 1:37 PM
F142148609: D53836.id166818.diff
Fri, Jan 16, 12:25 PM
Unknown Object (File)
Mon, Jan 12, 1:18 PM
Unknown Object (File)
Mon, Jan 12, 11:24 AM
Unknown Object (File)
Thu, Jan 8, 10:34 AM
Unknown Object (File)
Dec 14 2025, 3:01 PM
Unknown Object (File)
Dec 14 2025, 2:51 PM
Unknown Object (File)
Dec 6 2025, 6:13 AM
Subscribers

Details

Summary
Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the VLAN flag should be set if either of thsee bits is.  In the
OpenBSD driver these are AQ_RXDESC_TYPE_VLAN and AQ_RXDESC_TYPE_VLAN2
rather than a magic number 0x60.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2025, 3:57 PM
This revision was automatically updated to reflect the committed changes.