Differential D53911

strfmon: Add tests for Austin Group Defect 1199
ClosedPublic
Actions

Authored by jlduran on Wed, Nov 26, 2:52 AM.

Tags

None

Referenced Files

	F140038931: D53911.diff
	Fri, Dec 19, 9:52 AM

	Unknown Object (File)
	Mon, Dec 15, 9:22 PM

	Unknown Object (File)
	Mon, Dec 15, 11:49 AM

	Unknown Object (File)
	Mon, Dec 8, 7:57 AM

	Unknown Object (File)
	Mon, Dec 8, 7:55 AM

	Unknown Object (File)
	Wed, Dec 3, 9:56 AM

	Unknown Object (File)
	Tue, Dec 2, 9:55 PM

	Unknown Object (File)
	Mon, Dec 1, 9:47 PM

View All 11 Files

Subscribers

Details

Reviewers

Commits

rG33189f868ab9: strfmon: Add tests for Austin Group Defect 1199
rG7745ece2819e: strfmon: Add tests for Austin Group Defect 1199
rGd3dbfab0d04e: strfmon: Add tests for Austin Group Defect 1199
rG19e153004fb6: strfmon: Add tests for Austin Group Defect 1199

Summary

Add tests for The Open Group Base Specifications Issue 8[1], Austin
Group Defect 1199[2].

Items marked with XXX represent an invalid output. These items will be
fixed in subsequent commits.

Notice that an existing test is now considered invalid.

Our locale definitions do not include int_p_sep_by_space nor
int_n_sep_by_space[3]. Those will be addressed in a subsequent commit.
However, the CLDR project defines them as "0", which causes the output
to appear as "USD123.45". If our locale definitions were to set the
international {n,p}_sep_by_space to "1", the output would display as the
expected "USD 123.45".

While here, use the SPDX license identifier and add my name to the
file.

[1]: https://pubs.opengroup.org/onlinepubs/9799919799/functions/strfmon.html
[2]: https://www.austingroupbugs.net/view.php?id=1199
[3]: https://unicode-org.atlassian.net/browse/CLDR-237

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68875
Build 65758: arc lint + arc unit

Event Timeline

jlduran created this revision.Wed, Nov 26, 2:52 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 26, 2:52 AM

jlduran requested review of this revision.Wed, Nov 26, 2:52 AM

Harbormaster completed remote builds in B68847: Diff 167102.Wed, Nov 26, 2:52 AM

jlduran added a child revision: D53912: strfmon: EINVAL if the '+' flag and both signs are empty.Wed, Nov 26, 2:52 AM

jlduran added a reviewer: kib.Wed, Nov 26, 3:01 AM

Would you add a link to the actual defect page? Is it public?

lib/libc/tests/stdlib/strfmon_test.c
15	Should be ordered alphabetically

jlduran edited the summary of this revision. (Show Details)Wed, Nov 26, 2:30 PM

Address style(9) suggestions:

Sort includes

Harbormaster completed remote builds in B68875: Diff 167134.Wed, Nov 26, 3:05 PM

kib accepted this revision.Wed, Nov 26, 5:05 PM

This revision is now accepted and ready to land.Wed, Nov 26, 5:05 PM

Closed by commit rG19e153004fb6: strfmon: Add tests for Austin Group Defect 1199 (authored by jlduran). · Explain WhyWed, Nov 26, 8:35 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG19e153004fb6: strfmon: Add tests for Austin Group Defect 1199.

jlduran added a commit: rGd3dbfab0d04e: strfmon: Add tests for Austin Group Defect 1199.Wed, Dec 3, 2:38 AM

jlduran added a commit: rG7745ece2819e: strfmon: Add tests for Austin Group Defect 1199.

jlduran added a commit: rG33189f868ab9: strfmon: Add tests for Austin Group Defect 1199.

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

stdlib/

80 lines

Diff 167134

lib/libc/tests/stdlib/strfmon_test.c

Loading...