Differential D6468
Silence /usr/bin/top compiler warnings Authored by rwestlun_gmail.com on May 19 2016, 8:55 PM. Tags None Referenced Files
Subscribers
Details
The /contrib/top code is no longer maintained upstream (last pulled 16 years ago). The The 5 warnings that remain are due to undeclared ncurses references. I didn't include No functional change. Works for me.
Diff Detail
Event TimelineComment Actions Please upload a diff with full context (generate the patch with -U999999). Tangential, and please don't do it at the same time as these changes, but maybe top should be moved out of contrib/ if upstream is gone. Comment Actions LGTM modulo comments. This program could use ANSIfication of function definitions and a liberal dosing of style(9). That can wait for a later cleanup, though.
Comment Actions Agreed. I'm happy to do it, but I was wary of too many ANSI and style(9) changes without knowing whether they would be accepted. If someone commits this, I'll continue with the cleanup.
Comment Actions Updated to address comments:
For the two header files that I created, I copied the copyright notices from the .c files. All the original headers (including machine.h) never had copyright notices in them in the upstream sources. I've left them as they are. If it's appropriate, I can add the copyright notices to them in later cleanup. Comment Actions There are a few more warnings that need to be cured: /usr/src/svn/usr.bin/top/../../contrib/top/display.c:287:6: warning: implicit declaration of function 'tputs' is invalid in C99 [-Wimplicit-function-declaration]
Move_to(x_lastpid, y_lastpid);
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.h:10:23: note: expanded from macro 'Move_to'
#define Move_to(x, y) TCputs(tgoto(cursor_motion, x, y))
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.h:8:21: note: expanded from macro 'TCputs'
#define TCputs(str) tputs(str, 1, putstdout)
^
1 warning generated.
cc -O2 -pipe -O2 -pipe -DHAVE_GETOPT -DHAVE_STRERROR -DORDER -I/usr/src/svn/usr.bin/top -I/usr/src/svn/usr.bin/top/../../contrib/top -I. -g -MD -MF.depend.machine.o -MTmachine.o -std=gnu99 -fstack-protector-strong -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c /usr/src/svn/usr.bin/top/machine.c -o machine.o
cc -O2 -pipe -O2 -pipe -DHAVE_GETOPT -DHAVE_STRERROR -DORDER -I/usr/src/svn/usr.bin/top -I/usr/src/svn/usr.bin/top/../../contrib/top -I. -g -MD -MF.depend.screen.o -MTscreen.o -std=gnu99 -fstack-protector-strong -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c /usr/src/svn/usr.bin/top/../../contrib/top/screen.c -o screen.o
/usr/src/svn/usr.bin/top/../../contrib/top/screen.c:136:19: warning: implicit declaration of function 'tgetent' is invalid in C99 [-Wimplicit-function-declaration]
if ((status = tgetent(termcap_buf, term_name)) != 1)
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.c:154:9: warning: implicit declaration of function 'tgetflag' is invalid in C99 [-Wimplicit-function-declaration]
if (tgetflag("hc"))
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.c:161:26: warning: implicit declaration of function 'tgetnum' is invalid in C99 [-Wimplicit-function-declaration]
if ((screen_length = tgetnum("li")) <= 0)
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.c:318:2: warning: implicit declaration of function 'tputs' is invalid in C99 [-Wimplicit-function-declaration]
putcap(terminal_init);
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.h:9:44: note: expanded from macro 'putcap'
#define putcap(str) (void)((str) != NULL ? TCputs(str) : 0)
^
/usr/src/svn/usr.bin/top/../../contrib/top/screen.h:8:21: note: expanded from macro 'TCputs'
#define TCputs(str) tputs(str, 1, putstdout)
^
4 warnings generated.Comment Actions Yeep. Fixing these is harder I noticed after adding curses.h and term.h. This is a good first step.. I'll commit the changes you provided. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||