Page MenuHomeFreeBSD
Differential D53186

release: split up Oracle Cloudware tools
ClosedPublic
Actions

Authored by dch on Oct 18 2025, 12:41 PM.
Tags
None
Referenced Files
F151296487: D53186.id164494.diff
Tue, Apr 7, 9:54 AM
F151282934: D53186.id164583.diff
Tue, Apr 7, 7:47 AM
F151275641: D53186.diff
Tue, Apr 7, 6:40 AM
Unknown Object (File)
Mon, Apr 6, 10:31 AM
Unknown Object (File)
Sun, Apr 5, 7:37 PM
Unknown Object (File)
Sun, Apr 5, 6:49 AM
Unknown Object (File)
Fri, Apr 3, 9:38 AM
Unknown Object (File)
Wed, Mar 25, 1:37 AM
View All 53 Files
Subscribers
imp
ivy
jrtc27

Details

Reviewers
cperciva
Group Reviewers
releng
Commits
rGb6cde3ca5dbf: release: split up Oracle Cloudware tools
rGe27e5b6b0177: release: split up Oracle Cloudware tools
rG81d807a90611: release: split up Oracle Cloudware tools
Summary

Sometimes one or the other but not both tools are present; this ensures
that all cases are correctly handled.

Reported by: cperciva
Sponsored by: SkunkWerks, GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dch created this revision.Oct 18 2025, 12:41 PM
Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptOct 18 2025, 12:41 PM
dch requested review of this revision.Oct 18 2025, 12:41 PM
Harbormaster completed remote builds in B67897: Diff 164494.Oct 18 2025, 12:41 PM
dch added reviewers: releng, cperciva.Oct 18 2025, 1:00 PM
ivy added inline comments.Oct 18 2025, 1:03 PM
release/Makefile.oracle
30–31

not a review (i'm not familiar with this code at all) but as a general suggestion, it might be nice to use ${LOCALBASE} here rather than hardcoding /usr/local. i'm trying to get all of release/ to do this, although it's a fairly long-term project.

cperciva accepted this revision.Oct 19 2025, 4:01 AM

LGTM. Please commit, MFC After: 3 days, and poke me to cherry-pick to releng/15.0 before BETA3.

This revision is now accepted and ready to land.Oct 19 2025, 4:01 AM
Closed by commit rG81d807a90611: release: split up Oracle Cloudware tools (authored by dch). · Explain WhyOct 20 2025, 9:38 AM
This revision was automatically updated to reflect the committed changes.
dch added a commit: rG81d807a90611: release: split up Oracle Cloudware tools.
dch added inline comments.Oct 20 2025, 1:16 PM
release/Makefile.oracle
30–31

this is a very good idea, but I'll leave it til after BETA3 goes through as
I'm wary of breaking yet another build. Once I MFC this, I can add
this to CURRENT & STABLE alone. I copy-pasta-ed it from the AWS EC2 images
so we could change all of them across the board.

dch added a commit: rGe27e5b6b0177: release: split up Oracle Cloudware tools.Oct 22 2025, 8:17 AM
dch added a commit: rGb6cde3ca5dbf: release: split up Oracle Cloudware tools.Oct 22 2025, 8:25 AM

Revision Contents
Changeset List

PathSize
release/
19 lines

Diff 164583

View Options

release/Makefile.oracle

Loading...