Hi,

Thank you for submitting this patch.
Can you please provide a commit message that explains this change.
For example questions that immediately arise:

1. What "newly exposed RSS hash key API" you are talking about (link to the commits that added this API)?
2. Why it is ok to remove the #ifdef RSS?
3. Why do you also remove the #ifdef RSS in ena_datapath.c?
4. How did you test the change?

Thanks!

In D53100#1213606, @akiyano_amazon.com wrote:

Hi,

Thank you for submitting this patch.
Can you please provide a commit message that explains this change.
For example questions that immediately arise:

1. What "newly exposed RSS hash key API" you are talking about (link to the commits that added this API)?
2. Why it is ok to remove the #ifdef RSS?
3. Why do you also remove the #ifdef RSS in ena_datapath.c?
4. How did you test the change?

Thanks!

Sorry, I wish I was better at reviews of patch series. This is not my favorite review tool.

This is one of many patches, starting with https://reviews.freebsd.org/D53089 and ending with https://reviews.freebsd.org/D53104. The goal is to achieve consistent hashing for TCP ingress/egress by exposing the hashing parts of RSS to drivers, so that all NICs use the same hash key and algo.

Testing was done with netflix traffic on mlx5, ixl and ix using https://reviews.freebsd.org/D53105

Looking at ena_datapath, it looks like I also need to unifdef the check for toeplitz being enabled.

I built and installed the latest kernel with this patchset in AWS and ran a network sanity check with iperf and all looks good.

turned on net.inet.tcp.input_verify_hash with sysctl net.inet.tcp.input_verify_hash=1

ran traffic

lookede at

sysctl net.inet.tcp.input_nohash
sysctl net.inet.tcp.input_badhash

and both were 0

no prints to dmesg

commit lgtm.

In D53100#1214833, @akiyano_amazon.com wrote:

I built and installed the latest kernel with this patchset in AWS and ran a network sanity check with iperf and all looks good.

turned on net.inet.tcp.input_verify_hash with sysctl net.inet.tcp.input_verify_hash=1

ran traffic

lookede at

sysctl net.inet.tcp.input_nohash
sysctl net.inet.tcp.input_badhash

and both were 0

no prints to dmesg

commit lgtm.

Thank you so much for quick and complete testing. Much appreciated!

In D53100#1214836, @gallatin wrote:

In D53100#1214833, @akiyano_amazon.com wrote:

I built and installed the latest kernel with this patchset in AWS and ran a network sanity check with iperf and all looks good.

turned on net.inet.tcp.input_verify_hash with sysctl net.inet.tcp.input_verify_hash=1

ran traffic

lookede at

sysctl net.inet.tcp.input_nohash
sysctl net.inet.tcp.input_badhash

and both were 0

no prints to dmesg

commit lgtm.

Thank you so much for quick and complete testing. Much appreciated!

Sure :) happy to help with testing.