Why all these += instead of =?

USES=sqlite?

Why .pre/.post.mk?

Indented comments get passed to sh(1). Left-aligned comments are actual make(1) comments.

What do these comments add?

Why USES=compiler?

I believe that you'll need to set svn:keywords for this to be expanded.

I don't see any good reason to have both substitutions, it's not as if their value can change. Why not just write the files correctly and not do any of those substitutions ?

Fair challenge. I'm happy to change it if you want. My reasons for doing it were:

1. Both files could change if %%PREFIX%% is not default.
2. joshruehlig@gmail.com provided me with an rc.d script which he used across many FreeNAS packages with no variation because of the name substitution. I used it in my multimedia/emby-server port, and the differentiation between RC_NAME and PORTNAME was an easy way to remember when to use - or _ for ports with a hyphen in their name.

Of course both files should still have the %%PREFIX%% substitution, because it is a variable. The two other are constants, we don't use substitutions for constants, because, well, they don't change, so they don't need to be able to change.

Also, for new ports, the rc filename should == the rc name. So in this case, both should be forked_daapd. Really, it should be for all ports, but it's a long term task.

(and the rc filename should == the package name, replacing - with _ if it contains one.)

Ok, I will prepare a separate diff to remove any substitutions that are not %%PREFIX%%.
Just to be clear - are you suggesting the PORTNAME should be changed to replace - with _? Move the folder too? If so, maybe it is better to revert the commit and redo?

Ok, new diff prepared for review here:
https://reviews.freebsd.org/D6329