Page MenuHomeFreeBSD

audio/forked-daapd: Remove substitions which are not related to variables
ClosedPublic

Authored by woodsb02 on May 11 2016, 11:29 PM.

Details

Summary

audio/forked-daapd: Remove substitions which are not related to variables

Remove %%PORTNAME%% and %%RC_NAME%% from:

  • files/forked-daapd.in
  • files/pkg-message.in

Reported by: mat (mentor)
Approved by: xxx (mentor)

Test Plan

poudriere testport audio/forked-daapd

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

woodsb02 retitled this revision from to audio/forked-daapd: Remove substitions which are not related to variables.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added a reviewer: mat.
woodsb02 added subscribers: adamw, koobs.
mat edited edge metadata.
This revision is now accepted and ready to land.May 12 2016, 7:27 AM
This revision was automatically updated to reflect the committed changes.

Apologies, I accidentally committed with the "approved by: xxx (mentor)"

How do we fix that?

Apologies, I accidentally committed with the "approved by: xxx (mentor)"

How do we fix that?

We don't, history is immutable.

It's a one more good reason for not writing commit messages beforehand. Best is to writes notes, about what needs to be in it, and write the commit message, in full, when committing.

Ok. Kicking myself for that one.