Page MenuHomeFreeBSD
Differential D47759

cxgbe tom: Halve the size of offload transmit software descriptors
ClosedPublic
Actions

Authored by jhb on Nov 26 2024, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 1:47 AM
Unknown Object (File)
Mon, Apr 27, 6:16 PM
Unknown Object (File)
Tue, Apr 21, 5:51 AM
Unknown Object (File)
Mon, Apr 20, 6:38 PM
Unknown Object (File)
Wed, Apr 15, 1:08 PM
Unknown Object (File)
Mon, Apr 13, 3:40 PM
Unknown Object (File)
Fri, Apr 10, 1:27 AM
Unknown Object (File)
Sat, Apr 4, 4:30 PM
View All 82 Files
Subscribers
ae
imp

Details

Reviewers
np
Commits
rG4df8a30e54b6: cxgbe tom: Halve the size of offload transmit software descriptors
rGe27bb92b6fa6: cxgbe tom: Halve the size of offload transmit software descriptors
rG5a3885768490: cxgbe tom: Halve the size of offload transmit software descriptors
Summary

Use bitfields to pack tx_credits and plen into a single 32-bit word.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 26 2024, 4:47 PM
Herald added subscribers: ae, imp. · View Herald TranscriptNov 26 2024, 4:47 PM
jhb requested review of this revision.Nov 26 2024, 4:47 PM
Harbormaster completed remote builds in B60788: Diff 146980.Nov 26 2024, 4:47 PM
jhb added a child revision: D47760: cxgbe tom: Make t4_push_frames static to t4_cpl_io.c.Nov 26 2024, 4:48 PM
jhb added a comment.Nov 26 2024, 5:09 PM

This isn't required for the other changes. Originally I was going to add another 1-bit field to struct ofld_tx_sdesc and had done this as a prep (I stole the extra bit from plen). However, I ended up not needing that change but still kept this as it does reduce memory usage a bit.

np accepted this revision.Sep 11 2025, 6:40 PM
This revision is now accepted and ready to land.Sep 11 2025, 6:40 PM
Closed by commit rG5a3885768490: cxgbe tom: Halve the size of offload transmit software descriptors (authored by jhb). · Explain WhySep 11 2025, 9:13 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG5a3885768490: cxgbe tom: Halve the size of offload transmit software descriptors.
np added a commit: rGe27bb92b6fa6: cxgbe tom: Halve the size of offload transmit software descriptors.Oct 3 2025, 12:04 AM
jhb added a commit: rG4df8a30e54b6: cxgbe tom: Halve the size of offload transmit software descriptors.Jan 29 2026, 3:40 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
cxgbei/
2 lines
iw_cxgbe/
2 lines
tom/
16 lines
4 lines
7 lines
2 lines

Diff 161931

View Options

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...
View Options

sys/dev/cxgbe/iw_cxgbe/qp.c

Loading...
View Options

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...
View Options

sys/dev/cxgbe/tom/t4_tls.c

Loading...
View Options

sys/dev/cxgbe/tom/t4_tom.h

Loading...
View Options

sys/dev/cxgbe/tom/t4_tom.c

Loading...