Page MenuHomeFreeBSD
Differential D6311

Allwinner add H3 support
ClosedPublic
Actions

Authored by manu on May 10 2016, 7:04 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, May 20, 5:01 PM
Unknown Object (File)
Mon, May 20, 5:01 PM
Unknown Object (File)
Mon, May 20, 5:01 PM
Unknown Object (File)
Mon, May 20, 3:42 AM
Unknown Object (File)
Apr 26 2024, 10:37 PM
Unknown Object (File)
Apr 26 2024, 10:59 AM
Unknown Object (File)
Apr 25 2024, 11:05 PM
Unknown Object (File)
Mar 20 2024, 10:20 AM
View All 44 Files
Subscribers
andrew
imp
jmcneill
loos

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS299688: Add support for Allwinner H3 SoC.
Summary

Add H3 support.
For now SMP, EHCI GPIO and pinctrl, this is what's it described in the DTS.

Test Plan

Tested on Orange Pi One.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3684
Build 3727: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 16154.May 10 2016, 7:04 PM
manu retitled this revision from to Allwinner add H3 support.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: loos, andrew, imp. · View Herald TranscriptMay 10 2016, 7:04 PM
jmcneill accepted this revision.May 10 2016, 7:59 PM
jmcneill added a reviewer: jmcneill.
jmcneill added a subscriber: jmcneill.
jmcneill added inline comments.
sys/arm/allwinner/clk/aw_pll.c
467

Can you add A23_PLL1_FACTOR_M/K/N defines so you're not referring to A31 stuff here? I know it's redundant but it makes it a bit easier when glancing at the code that there isn't a typo.

600

I suppose these should be sorted by compat string and not the data column.

This revision is now accepted and ready to land.May 10 2016, 7:59 PM
manu added inline comments.May 10 2016, 8:09 PM
sys/arm/allwinner/clk/aw_pll.c
467

Maybe a comment would do the job then ?
I'm not really ok for adding duplicate defines ...

600

Tomato, Potato (c) Fez.
But yeah I see your point, I'll change that.

manu updated this revision to Diff 16165.May 10 2016, 9:14 PM
manu edited edge metadata.

Add defines for A23 PLLs so it's less confusing.

This revision now requires review to proceed.May 10 2016, 9:14 PM
manu marked 4 inline comments as done.May 10 2016, 9:14 PM
jmcneill accepted this revision.May 10 2016, 9:17 PM
jmcneill edited edge metadata.
This revision is now accepted and ready to land.May 10 2016, 9:17 PM
Closed by commit rS299688: Add support for Allwinner H3 SoC. (authored by manu). · Explain WhyMay 13 2016, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
1 line
10 lines
1 line
24 lines
1 line
1 line
clk/
3 lines
25 lines
6 lines
h3/
4 lines
147 lines
60 lines
h3/
std.h3
std.allwinner
6 lines
1 line
conf/
1 line
conf/
1 line

Diff 16154

View Options

sys/arm/allwinner/a10_ehci.c

Loading...
View Options

sys/arm/allwinner/a10_gpio.c

Loading...
View Options

sys/arm/allwinner/allwinner_machdep.h

Loading...
View Options

sys/arm/allwinner/allwinner_machdep.c

Loading...
View Options

sys/arm/allwinner/aw_ccu.c

Loading...
View Options

sys/arm/allwinner/aw_usbphy.c

Loading...
View Options

sys/arm/allwinner/clk/aw_gate.c

Loading...
View Options

sys/arm/allwinner/clk/aw_pll.c

Loading...
View Options

sys/arm/allwinner/clk/aw_usbclk.c

Loading...
View Options

sys/arm/allwinner/h3/files.h3

Loading...
View Options

sys/arm/allwinner/h3/h3_padconf.c

Loading...
View Options

sys/arm/allwinner/h3/h3_r_padconf.c

Loading...
View Options

sys/arm/allwinner/h3/std.h3

Loading...
View Options

sys/arm/allwinner/std.allwinner

Loading...
View Options

sys/arm/conf/ALLWINNER

Loading...
View Options

sys/conf/options.arm

Loading...