foo="I \"like\" C++"
gives the value 'I "like" C++' to the variable 'foo'.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3649 Build 3692: arc lint + arc unit
Event Timeline
| sbin/devd/devd.cc | ||
|---|---|---|
| 428 | Don't you want to keep going? This stops after the first '\' I think? Maybe just do this: while (*src) {
if (*src == '\\')
src++;
else
*dst++ = *src++;
}
*dst = '\0';Also, 'dst' isn't initialized. | |
| sbin/devd/devd.cc | ||
|---|---|---|
| 448 | This log statement is now inaccurate. I think you should log the fixed val instead of the raw val. | |
Comment Actions
Fix issues raised in the review.
Updating D6286: Implement quote escaping. String values may now contain " if you
it is preceded by \.
| sbin/devd/devd.cc | ||
|---|---|---|
| 428 | Just made it apply to ", but you're right. I don't know what I was thinking. | |
Comment Actions
Something's screwed up with this review. When I try to view just your change from Sunday, it looks like it reverts the original change. But when I try to view both changes together, they look correct. What's going on?
Also, your more recent change didn't correctly fix the log message in var_list::set_variable.