Implement quote escaping. String values may now contain " if you it is preceded by \.

[imp]

Summary

foo="I \"like\" C++"

gives the value 'I "like" C++' to the variable 'foo'.

[jhb]

sbin/devd/devd.cc

428 ↗

(On Diff #16095)

Don't you want to keep going? This stops after the first '\' I think? Maybe just do this:

while (*src) {
    if (*src == '\\')
        src++;
    else
       *dst++ = *src++;
}
*dst = '\0';

Also, 'dst' isn't initialized.

[asomers]

sbin/devd/devd.cc

448 ↗

(On Diff #16095)

This log statement is now inaccurate. I think you should log the fixed val instead of the raw val.

[asomers]

Formally requesting a change for the log issue, just so it doesn't get lost.

[imp]

Fix issues raised in the review.

Updating D6286: Implement quote escaping. String values may now contain " if you

it is preceded by \.

[imp]

sbin/devd/devd.cc

428 ↗

(On Diff #16095)

Just made it apply to ", but you're right. I don't know what I was thinking.

[asomers]

Something's screwed up with this review. When I try to view just your change from Sunday, it looks like it reverts the original change. But when I try to view both changes together, they look correct. What's going on?

Also, your more recent change didn't correctly fix the log message in var_list::set_variable.