Page MenuHomeFreeBSD
Differential D6277

Pass node to the gpio_pin_get_by_ofw_XXX functions
ClosedPublic
Actions

Authored by gonzo on May 9 2016, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 3:05 AM
Unknown Object (File)
Wed, Oct 8, 7:37 AM
Unknown Object (File)
Aug 14 2025, 9:12 PM
Unknown Object (File)
Aug 14 2025, 9:02 PM
Unknown Object (File)
Aug 2 2025, 5:49 AM
Unknown Object (File)
Jul 28 2025, 2:44 PM
Unknown Object (File)
Jul 28 2025, 11:07 AM
Unknown Object (File)
Jul 26 2025, 12:46 PM
View All 87 Files
Subscribers
andrew
imp
loos

Details

Reviewers
mmel
Commits
rS299384: Pass device tree node as a part of gpio_pin_get_by_ofw_XXX API
Summary

Current API assumes that "gpios" property belongs to the device's node but for some binding it's not true: gpiokeys has set of child nodes with this property.

Patch adds new argument instead of replacing device_t because device_t will be used to track ownership for allocated pins

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gonzo updated this revision to Diff 16082.May 9 2016, 8:35 PM
gonzo retitled this revision from to Pass node to the gpio_pin_get_by_ofw_XXX functions.
gonzo updated this object.
gonzo edited the test plan for this revision. (Show Details)
gonzo added a reviewer: mmel.
gonzo set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: loos, andrew, imp. · View Herald TranscriptMay 9 2016, 8:35 PM
gonzo added a child revision: D6279: Add gpiokeys driver.May 9 2016, 8:56 PM
mmel accepted this revision.May 10 2016, 4:26 AM
mmel edited edge metadata.
mmel added inline comments.
sys/dev/gpio/ofw_gpiobus.c
67

KASSERT(consumer != NULL && cnode > 0, ...) ?

126

Same as above - KASSERT(consumer != NULL && cnode > 0, ...) ?

This revision is now accepted and ready to land.May 10 2016, 4:26 AM
Closed by commit rS299384: Pass device tree node as a part of gpio_pin_get_by_ofw_XXX API (authored by gonzo). · Explain WhyMay 10 2016, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
nvidia/
6 lines
dev/
gpio/
10 lines
45 lines

Diff 16082

View Options

sys/arm/nvidia/tegra_sdhci.c

Loading...
View Options

sys/dev/gpio/gpiobusvar.h

Loading...
View Options

sys/dev/gpio/ofw_gpiobus.c

Loading...