Pass node to the gpio_pin_get_by_ofw_XXX functions
ClosedPublic
Actions

Authored by gonzo on May 9 2016, 8:35 PM.

Details

Reviewers

Commits

rS299384: Pass device tree node as a part of gpio_pin_get_by_ofw_XXX API

Summary

Current API assumes that "gpios" property belongs to the device's node but for some binding it's not true: gpiokeys has set of child nodes with this property.

Patch adds new argument instead of replacing device_t because device_t will be used to track ownership for allocated pins

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo updated this revision to Diff 16082.May 9 2016, 8:35 PM

gonzo retitled this revision from to Pass node to the gpio_pin_get_by_ofw_XXX functions.

gonzo updated this object.

gonzo edited the test plan for this revision. (Show Details)

gonzo added a reviewer: mmel.

gonzo set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: loos, andrew, imp. · View Herald TranscriptMay 9 2016, 8:35 PM

gonzo added a child revision: D6279: Add gpiokeys driver.May 9 2016, 8:56 PM

mmel accepted this revision.May 10 2016, 4:26 AM

mmel edited edge metadata.

mmel added inline comments.

sys/dev/gpio/ofw_gpiobus.c
67 ↗	(On Diff #16082)	KASSERT(consumer != NULL && cnode > 0, ...) ?
126 ↗	(On Diff #16082)	Same as above - KASSERT(consumer != NULL && cnode > 0, ...) ?