tzcode: Fix TZ for non-setugid programs
ClosedPublic
Actions

Authored by des on Fri, Aug 22, 12:36 AM.

Details

Reviewers

cy
imp
jhb

Commits

rGa6b19979bf13: tzcode: Fix TZ for non-setugid programs

Summary

The previous commit had the desired effect for setugid programs, but
broke TZ for everyone else. I didn't notice because my test cases
swap out /etc/localtime instead of setting TZ, so add a test case
that sets TZ.

Fixes: b6ea2513f776 ("tzcode: Limit TZ for setugid programs")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des requested review of this revision.Fri, Aug 22, 12:36 AM

des created this revision.

Harbormaster completed remote builds in B66439: Diff 160787.Fri, Aug 22, 12:36 AM

rpokala added a subscriber: rpokala.Fri, Aug 22, 1:50 AM

rpokala added inline comments.

lib/libc/tests/stdtime/detect_tz_changes_test.c
41	Please fix the indentation -- either align, or else remove extra spaces.

LGTM

This revision is now accepted and ready to land.Fri, Aug 22, 6:03 AM

des marked an inline comment as done.Fri, Aug 22, 7:21 AM

des added inline comments.

lib/libc/tests/stdtime/detect_tz_changes_test.c
41	The indentation is perfectly fine as it is.

Closed by commit rGa6b19979bf13: tzcode: Fix TZ for non-setugid programs (authored by des). · Explain WhyFri, Aug 22, 7:30 AM

This revision was automatically updated to reflect the committed changes.

des marked an inline comment as done.

des added a commit: rGa6b19979bf13: tzcode: Fix TZ for non-setugid programs.

Revision Contents
Changeset List

Path

Size

contrib/

tzcode/

localtime.c

11 lines

lib/

libc/

tests/

stdtime/

detect_tz_changes_test.c

61 lines

Diff 160799

View Options

contrib/tzcode/localtime.c