Page MenuHomeFreeBSD
Differential D51992

virtio/mmio: Remove the unused virtio_mmio_if.m
ClosedPublic
Actions

Authored by andrew on Aug 18 2025, 9:57 AM.
Tags
None
Referenced Files
F151690719: D51992.id160714.diff
Fri, Apr 10, 1:21 AM
Unknown Object (File)
Mon, Apr 6, 9:08 AM
Unknown Object (File)
Wed, Apr 1, 8:54 PM
Unknown Object (File)
Wed, Apr 1, 2:55 AM
Unknown Object (File)
Sun, Mar 22, 6:37 AM
Unknown Object (File)
Sun, Mar 22, 4:34 AM
Unknown Object (File)
Mar 3 2026, 1:48 PM
Unknown Object (File)
Feb 28 2026, 8:03 AM
View All 58 Files
Subscribers
imp
jrtc27

Details

Reviewers
br
imp
Commits
rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m
Summary

The only driver I know that implemented this interface was removed 7
months ago. Remove the interface and platform from the softc.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66315
Build 63198: arc lint + arc unit

Event Timeline

andrew created this revision.Aug 18 2025, 9:57 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 18 2025, 9:57 AM
andrew requested review of this revision.Aug 18 2025, 9:57 AM
Harbormaster completed remote builds in B66315: Diff 160532.Aug 18 2025, 9:57 AM
andrew added a child revision: D51993: virtio: Remove the unused poll method.Aug 18 2025, 9:57 AM
imp accepted this revision.Aug 18 2025, 2:28 PM

What was the last driver?

This revision is now accepted and ready to land.Aug 18 2025, 2:28 PM
andrew added a comment.Aug 18 2025, 3:44 PM

It was a beri driver in sys/dev/beri/virtio/virtio_mmio_platform.c

jrtc27 added a subscriber: jrtc27.Aug 18 2025, 5:14 PM
jrtc27 added inline comments.
sys/dev/virtio/mmio/virtio_mmio.c
104–115
160

I believe this method is now never implemented? Presumably it was for cache coherence or similar in the dodgy BERI VirtIO world; virtqueue_poll calls it just before virtqueue_dequeue.

andrew added inline comments.Aug 20 2025, 9:16 AM
sys/dev/virtio/mmio/virtio_mmio.c
160

I already removed it in D51993

Closed by commit rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m (authored by andrew). · Explain WhyAug 21 2025, 8:44 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
mmio/
1 line
36 lines
47 lines

Diff 160532

View Options

sys/dev/virtio/mmio/virtio_mmio.h

Loading...
View Options

sys/dev/virtio/mmio/virtio_mmio.c

Loading...
View Options

sys/dev/virtio/mmio/virtio_mmio_fdt.c

Loading...
View Options

sys/dev/virtio/mmio/virtio_mmio_if.m

Loading...