OptionalObsoleteFiles: Update Kerberos entries
ClosedPublic
Actions

Authored by ivy on Tue, Aug 12, 2:07 PM.

Details

Reviewers

des
cy

Group Reviewers

krb5

Commits

rG721c98dd89cc: OptionalObsoleteFiles: Update Kerberos entries

Summary

Consolidate the various lists of Kerberos files into three sets:
common files, files only installed by MIT Kerberos, and files only
installed by Heimdal. This avoids having to list the same files in
multiple places and makes the logic a lot easier to maintain.

The new file lists were created by comparing the actual result of
make installworld with the various options enabled or disabled.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66190
Build 63073: arc lint + arc unit

Event Timeline

ivy created this revision.Tue, Aug 12, 2:07 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 12, 2:07 PM

ivy requested review of this revision.Tue, Aug 12, 2:07 PM

Harbormaster completed remote builds in B66190: Diff 160241.Tue, Aug 12, 2:07 PM

ivy added a parent revision: D51859: Remove MK_GSSAPI.Tue, Aug 12, 2:08 PM

des accepted this revision.Tue, Aug 12, 2:59 PM

This revision is now accepted and ready to land.Tue, Aug 12, 2:59 PM

usr/lib/libkadm5clnt.so.11 should be in the Heimdal section

this suggests i missed something when testing, i'll do some more tests

This revision now requires review to proceed.Tue, Aug 12, 3:04 PM

Harbormaster completed remote builds in B66194: Diff 160246.Tue, Aug 12, 3:04 PM

further testing revealed that usr/lib/libkadm5clnt.a is also specific to Heimdal
(but not libkadm5clnt.so, which exists in both)

Harbormaster completed remote builds in B66196: Diff 160248.Tue, Aug 12, 3:22 PM

This is a lot to review.

This revision is now accepted and ready to land.Tue, Aug 12, 3:22 PM

In D51874#1185532, @cy wrote:

This is a lot to review.

yes, sorry. however, the result is a smaller file that should require less work in the future.

In D51874#1185538, @ivy wrote:

In D51874#1185532, @cy wrote:

This is a lot to review.

yes, sorry. however, the result is a smaller file that should require less work in the future.

I envisage Heimdal removal in 16. It's only there for 15 should someone need to use Heimdal for a KDC with principals encrypted using ancient unsupported ciphers. This would have still been a problem had we updated to Heimdal 7.8.0 instead. This is something I am working on: a migration path.

Closed by commit rG721c98dd89cc: OptionalObsoleteFiles: Update Kerberos entries (authored by ivy). · Explain WhyWed, Aug 20, 8:13 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG721c98dd89cc: OptionalObsoleteFiles: Update Kerberos entries.