Differential D50731

rtld: require MAP_GUARD support
ClosedPublic
Actions

Authored by brooks on Jun 6 2025, 7:33 PM.

Details

Reviewers

kib

Commits

rG0f434b2b5060: rtld: require MAP_GUARD support

Summary

MAP_GUARD was added prior to 12.0. We don't support such old kernels in
userspace so drop the support.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 66159
Build 63042: arc lint + arc unit

Event Timeline

brooks created this revision.Jun 6 2025, 7:33 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptJun 6 2025, 7:33 PM

brooks requested review of this revision.Jun 6 2025, 7:33 PM

Harbormaster completed remote builds in B64691: Diff 156654.Jun 6 2025, 7:33 PM

brooks added a child revision: D50732: amd64: assume the kernel supports RDFSBASE and RDGSBASE.Jun 6 2025, 7:34 PM

kib added inline comments.Jun 7 2025, 4:06 AM

libexec/rtld-elf/map_object.c
204	I suspect you intended base_flags = MAP_GUARD;

Fix base flags
Retain P_OSREL_MAP_GUARD definition

Harbormaster completed remote builds in B66159: Diff 160173.Aug 11 2025, 10:37 AM

kib accepted this revision.Aug 11 2025, 10:50 AM

kib added inline comments.

libexec/rtld-elf/map_object.c
28	Do we need sys/param.h at all?

This revision is now accepted and ready to land.Aug 11 2025, 10:50 AM

Closed by commit rG0f434b2b5060: rtld: require MAP_GUARD support (authored by brooks). · Explain WhyAug 11 2025, 11:19 AM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG0f434b2b5060: rtld: require MAP_GUARD support.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

map_object.c

6 lines

Diff 160173

View Options

libexec/rtld-elf/map_object.c

rtld: require MAP_GUARD supportClosedPublicActions