Page MenuHomeFreeBSD
Differential D50731

rtld: require MAP_GUARD support
ClosedPublic
Actions

Authored by brooks on Jun 6 2025, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 8:48 PM
Unknown Object (File)
Mon, Oct 6, 3:05 AM
Unknown Object (File)
Mon, Sep 22, 6:10 AM
Unknown Object (File)
Sun, Sep 21, 4:22 AM
Unknown Object (File)
Sat, Sep 20, 1:22 PM
Unknown Object (File)
Wed, Sep 17, 8:18 AM
Unknown Object (File)
Wed, Sep 17, 7:16 AM
Unknown Object (File)
Wed, Sep 17, 4:24 AM
View All 29 Files
Subscribers
bdragon
imp

Details

Reviewers
kib
Commits
rG0f434b2b5060: rtld: require MAP_GUARD support
Summary

MAP_GUARD was added prior to 12.0. We don't support such old kernels in
userspace so drop the support.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Jun 6 2025, 7:33 PM
Herald added subscribers: bdragon, imp. · View Herald TranscriptJun 6 2025, 7:33 PM
brooks requested review of this revision.Jun 6 2025, 7:33 PM
Harbormaster completed remote builds in B64691: Diff 156654.Jun 6 2025, 7:33 PM
brooks added a child revision: D50732: amd64: assume the kernel supports RDFSBASE and RDGSBASE.Jun 6 2025, 7:34 PM
kib added inline comments.Jun 7 2025, 4:06 AM
libexec/rtld-elf/map_object.c
204

I suspect you intended
base_flags = MAP_GUARD;

brooks updated this revision to Diff 160173.Aug 11 2025, 10:37 AM
  • Fix base flags
  • Retain P_OSREL_MAP_GUARD definition
Harbormaster completed remote builds in B66159: Diff 160173.Aug 11 2025, 10:37 AM
kib accepted this revision.Aug 11 2025, 10:50 AM
kib added inline comments.
libexec/rtld-elf/map_object.c
28

Do we need sys/param.h at all?

This revision is now accepted and ready to land.Aug 11 2025, 10:50 AM
Closed by commit rG0f434b2b5060: rtld: require MAP_GUARD support (authored by brooks). · Explain WhyAug 11 2025, 11:19 AM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG0f434b2b5060: rtld: require MAP_GUARD support.

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
6 lines

Diff 160175

View Options

libexec/rtld-elf/map_object.c

Loading...