Page MenuHomeFreeBSD
Differential D51717

Fix handling of empty bad memory addresses file
ClosedPublic
Actions

Authored by romain on Aug 3 2025, 6:45 PM.
Tags
None
Referenced Files
F131281931: D51717.id159702.diff
Mon, Oct 6, 1:00 PM
Unknown Object (File)
Sun, Oct 5, 9:16 PM
Unknown Object (File)
Fri, Oct 3, 4:49 PM
Unknown Object (File)
Fri, Oct 3, 1:26 PM
Unknown Object (File)
Wed, Oct 1, 12:37 PM
Unknown Object (File)
Wed, Sep 24, 3:06 AM
Unknown Object (File)
Tue, Sep 16, 5:37 AM
Unknown Object (File)
Tue, Sep 9, 1:02 PM
View All 20 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG77a0173ca956: vm_page: Fix handling of empty bad memory addresses file
rGaa326b970e36: vm_page: Fix handling of empty bad memory addresses file
rGf90940ce6eb7: vm_page: Fix handling of empty bad memory addresses file
Summary

After I MFC D51433, Mark Millard raised concerns about this change:
https://lists.freebsd.org/archives/dev-commits-src-branches/2025-August/023040.html

I have limited knowledge of this code, but as I understand it, their concerns apply when the user configure a bad address file and this file exist but is empty (0 lines, 0 bytes). If so, I propose to adjust the code this way to explicitly show what valid pre-conditions put a value in *list / *end, and otherwise both are set to NULL.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
vm/
10 lines

Diff 159702

View Options

sys/vm/vm_page.c

Loading...