Page MenuHomeFreeBSD
Differential D51717

Fix handling of empty bad memory addresses file
ClosedPublic
Actions

Authored by romain on Aug 3 2025, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 1:13 AM
Unknown Object (File)
Sun, Dec 7, 4:50 AM
Unknown Object (File)
Thu, Dec 4, 11:47 AM
Unknown Object (File)
Thu, Dec 4, 11:47 AM
Unknown Object (File)
Thu, Dec 4, 11:47 AM
Unknown Object (File)
Wed, Dec 3, 1:04 PM
Unknown Object (File)
Wed, Dec 3, 6:30 AM
Unknown Object (File)
Fri, Nov 28, 9:03 PM
View All 43 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG77a0173ca956: vm_page: Fix handling of empty bad memory addresses file
rGaa326b970e36: vm_page: Fix handling of empty bad memory addresses file
rGf90940ce6eb7: vm_page: Fix handling of empty bad memory addresses file
Summary

After I MFC D51433, Mark Millard raised concerns about this change:
https://lists.freebsd.org/archives/dev-commits-src-branches/2025-August/023040.html

I have limited knowledge of this code, but as I understand it, their concerns apply when the user configure a bad address file and this file exist but is empty (0 lines, 0 bytes). If so, I propose to adjust the code this way to explicitly show what valid pre-conditions put a value in *list / *end, and otherwise both are set to NULL.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
sys/
vm/
10 lines

Diff 159689

View Options

sys/vm/vm_page.c

Loading...