Page MenuHomeFreeBSD
Differential D51696

ufs: Remove uses of DEBUG_VFS_LOCKS
ClosedPublic
Actions

Authored by markj on Sat, Aug 2, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 13, 5:01 PM
Unknown Object (File)
Sun, Aug 10, 2:06 AM
Unknown Object (File)
Thu, Aug 7, 2:03 PM
Unknown Object (File)
Tue, Aug 5, 2:54 AM
Unknown Object (File)
Mon, Aug 4, 10:28 PM
Unknown Object (File)
Sun, Aug 3, 10:50 PM
Subscribers
imp

Details

Reviewers
kib
imp
olce
Commits
rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS
Summary

All of these assertions can reasonably be checked when plain INVARIANTS
is configured, there's no need to configure a separate option.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sat, Aug 2, 1:14 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Aug 2, 1:14 PM
markj requested review of this revision.Sat, Aug 2, 1:14 PM
Harbormaster completed remote builds in B65917: Diff 159624.Sat, Aug 2, 1:14 PM
markj added a parent revision: D51402: vfs: Move DEBUG_VFS_LOCKS checks to INVARIANTS.Sat, Aug 2, 1:14 PM
markj added a child revision: D51697: tmpfs: Remove uses of DEBUG_VFS_LOCKS.
kib added a comment.Sat, Aug 2, 2:07 PM

O think #ifdef's lines could be removed for the whole patch.

sys/ufs/ffs/ffs_softdep.c
14524–14525

I think the braces are not needed.

sys/ufs/ffs/ffs_vnops.c
510–511

Same there.

imp accepted this revision.Sat, Aug 2, 6:02 PM
This revision is now accepted and ready to land.Sat, Aug 2, 6:02 PM
markj updated this revision to Diff 159685.Sun, Aug 3, 3:58 PM
markj marked 2 inline comments as done.

Simply remove the ifdefs.

This revision now requires review to proceed.Sun, Aug 3, 3:58 PM
Harbormaster completed remote builds in B65943: Diff 159685.Sun, Aug 3, 3:58 PM
olce accepted this revision.Sun, Aug 3, 4:47 PM
This revision is now accepted and ready to land.Sun, Aug 3, 4:47 PM
kib accepted this revision.Sun, Aug 3, 6:06 PM
Closed by commit rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS (authored by markj). · Explain WhySun, Aug 3, 10:16 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS.

Revision Contents
Changeset List

PathSize
sys/
ufs/
ffs/
2 lines
2 lines
ufs/
2 lines
4 lines

Diff 159694

View Options

sys/ufs/ffs/ffs_softdep.c

Loading...
View Options

sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

sys/ufs/ufs/ufs_lookup.c

Loading...
View Options

sys/ufs/ufs/ufs_quota.c

Loading...