Page MenuHomeFreeBSD
Differential D51696

ufs: Remove uses of DEBUG_VFS_LOCKS
ClosedPublic
Actions

Authored by markj on Aug 2 2025, 1:14 PM.
Tags
None
Referenced Files
F163869554: D51696.id.diff
Sun, Jul 26, 6:21 PM
F163847194: D51696.id159624.diff
Sun, Jul 26, 2:48 PM
Unknown Object (File)
Sat, Jul 25, 6:21 AM
Unknown Object (File)
Fri, Jul 24, 8:35 PM
Unknown Object (File)
Fri, Jul 24, 5:21 PM
Unknown Object (File)
Fri, Jul 24, 8:39 AM
Unknown Object (File)
Fri, Jul 24, 8:02 AM
Unknown Object (File)
Thu, Jul 23, 9:58 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
kib
imp
olce
Commits
rGd033848a5e4c: ufs: Remove uses of DEBUG_VFS_LOCKS
rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS
Summary

All of these assertions can reasonably be checked when plain INVARIANTS
is configured, there's no need to configure a separate option.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65943
Build 62826: arc lint + arc unit

Event Timeline

markj created this revision.Aug 2 2025, 1:14 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 2 2025, 1:14 PM
markj requested review of this revision.Aug 2 2025, 1:14 PM
Harbormaster completed remote builds in B65917: Diff 159624.Aug 2 2025, 1:14 PM
markj added a parent revision: D51402: vfs: Move DEBUG_VFS_LOCKS checks to INVARIANTS.Aug 2 2025, 1:14 PM
markj added a child revision: D51697: tmpfs: Remove uses of DEBUG_VFS_LOCKS.
kib added a comment.Aug 2 2025, 2:07 PM

O think #ifdef's lines could be removed for the whole patch.

sys/ufs/ffs/ffs_softdep.c
14524–14525

I think the braces are not needed.

sys/ufs/ffs/ffs_vnops.c
510–511

Same there.

imp accepted this revision.Aug 2 2025, 6:02 PM
This revision is now accepted and ready to land.Aug 2 2025, 6:02 PM
markj updated this revision to Diff 159685.Aug 3 2025, 3:58 PM
markj marked 2 inline comments as done.

Simply remove the ifdefs.

This revision now requires review to proceed.Aug 3 2025, 3:58 PM
Harbormaster completed remote builds in B65943: Diff 159685.Aug 3 2025, 3:58 PM
olce accepted this revision.Aug 3 2025, 4:47 PM
This revision is now accepted and ready to land.Aug 3 2025, 4:47 PM
kib accepted this revision.Aug 3 2025, 6:06 PM
Closed by commit rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS (authored by markj). · Explain WhyAug 3 2025, 10:16 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4798f1e8f28d: ufs: Remove uses of DEBUG_VFS_LOCKS.
markj added a commit: rGd033848a5e4c: ufs: Remove uses of DEBUG_VFS_LOCKS.Aug 25 2025, 3:23 PM

Revision Contents
Changeset List

PathSize
sys/
ufs/
ffs/
2 lines
2 lines
ufs/
2 lines
4 lines

Diff 159685

View Options

sys/ufs/ffs/ffs_softdep.c

Loading...
View Options

sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

sys/ufs/ufs/ufs_lookup.c

Loading...
View Options

sys/ufs/ufs/ufs_quota.c

Loading...