ifconfig/ifbridge.c: add get_vlan_id()
ClosedPublic
Actions

Authored by ivy on Fri, Jul 25, 11:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 29, 9:48 AM

	Unknown Object (File)
	Tue, Jul 29, 9:00 AM

	Unknown Object (File)
	Tue, Jul 29, 6:45 AM

	Unknown Object (File)
	Tue, Jul 29, 6:42 AM

	Unknown Object (File)
	Tue, Jul 29, 6:15 AM

	Unknown Object (File)
	Mon, Jul 28, 6:00 PM

	Unknown Object (File)
	Mon, Jul 28, 2:23 PM

	Unknown Object (File)
	Sat, Jul 26, 3:12 PM

View All 11 Files

Subscribers

imp

Details

Reviewers

des
kp

Commits

rG8b728c63f777: ifconfig/ifbridge.c: add get_vlan_id()
rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id()

Summary

This is like get_val() but takes an ether_vlanid_t* and ensures the
value is a valid VLAN ID. This avoids redundant comparisons and
casting when parsing VLAN IDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Fri, Jul 25, 11:45 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 25, 11:45 PM

ivy requested review of this revision.Fri, Jul 25, 11:45 PM

Harbormaster completed remote builds in B65745: Diff 159164.Fri, Jul 25, 11:45 PM

standalone version of D51244 in an attempt to land these bridge changes before 15.0.

des accepted this revision.Mon, Jul 28, 2:08 PM

This revision is now accepted and ready to land.Mon, Jul 28, 2:08 PM

Closed by commit rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id() (authored by ivy). · Explain WhyMon, Jul 28, 2:10 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id().

ivy added a commit: rG8b728c63f777: ifconfig/ifbridge.c: add get_vlan_id().Sat, Aug 23, 12:12 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifbridge.c

28 lines

Diff 159319

View Options

ifconfig/ifbridge.c: add get_vlan_id()ClosedPublicActions