Page MenuHomeFreeBSD
Differential D51537

xargs: Convert tests to ATF
ClosedPublic
Actions

Authored by des on Jul 25 2025, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 12:05 AM
Unknown Object (File)
Mon, Oct 13, 12:05 AM
Unknown Object (File)
Sun, Oct 12, 6:35 PM
Unknown Object (File)
Sun, Oct 12, 12:33 PM
Unknown Object (File)
Sun, Oct 12, 1:37 AM
Unknown Object (File)
Sun, Oct 12, 1:37 AM
Unknown Object (File)
Sun, Oct 12, 1:37 AM
Unknown Object (File)
Sat, Oct 11, 4:04 PM
View All 43 Files
Subscribers
imp
kevans

Details

Reviewers
jmallett
kevans
Group Reviewers
tests
Commits
rGb26f93a46503: xargs: Convert tests to ATF

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65726
Build 62609: arc lint + arc unit

Event Timeline

des created this revision.Jul 25 2025, 6:58 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 25 2025, 6:58 PM
des requested review of this revision.Jul 25 2025, 6:58 PM
Harbormaster completed remote builds in B65726: Diff 159127.Jul 25 2025, 6:58 PM
des added a parent revision: D51536: xargs: Limit -n to {ARG_MAX}.Jul 25 2025, 6:58 PM
des added reviewers: jmallett, tests.Jul 25 2025, 6:59 PM
des mentioned this in D51536: xargs: Limit -n to {ARG_MAX}.Jul 25 2025, 7:26 PM
des updated this revision to Diff 159134.Jul 25 2025, 7:53 PM

{ARG_MAX} is variable, don't hardcode it

Harbormaster completed remote builds in B65729: Diff 159134.Jul 25 2025, 7:53 PM
des updated this revision to Diff 159135.Jul 25 2025, 7:56 PM

consistent naming

Harbormaster completed remote builds in B65730: Diff 159135.Jul 25 2025, 7:56 PM
kevans added a subscriber: kevans.Jul 26 2025, 4:07 PM
kevans added inline comments.
usr.bin/xargs/tests/xargs_test.sh
3

I think you'd mentioned you got some permission here from @jmallett out-of-band, please mention that explicitly in the commit message.

kevans accepted this revision as: kevans.Jul 26 2025, 4:08 PM
This revision is now accepted and ready to land.Jul 26 2025, 4:08 PM
jmallett added a comment.Jul 26 2025, 4:24 PM

I'm completely out of the loop on what's technically useful here, but happy to confirm that @des did get my permission to add a copyright. I'm glad to see xargs getting some good attention!

Closed by commit rGb26f93a46503: xargs: Convert tests to ATF (authored by des). · Explain WhyJul 27 2025, 1:10 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGb26f93a46503: xargs: Convert tests to ATF.

Revision Contents
Changeset List

PathSize
4 lines
usr.bin/
xargs/
tests/
3 lines
192 lines

Diff 159127

View Options

ObsoleteFiles.inc

Loading...
View Options

usr.bin/xargs/tests/Makefile

Loading...
View Options

usr.bin/xargs/tests/legacy_test.sh

Loading...
View Options

usr.bin/xargs/tests/regress.sh

Loading...
View Options

usr.bin/xargs/tests/xargs_test.sh

Loading...