Differential D51369

arm64: Fix the sign in ID registers
ClosedPublic
Actions

Authored by andrew on Jul 17 2025, 11:32 AM.

Details

Reviewers

manu

Group Reviewers

arm64

Commits

rG118bfc9f53ac: arm64: Fix the sign in ID registers

Summary

Some ID registers use 0b0000 to indicate a feature is enabled, and
0b1111 to indicate it's not. In these cases we need to tell the kernel
to treat the value as a signed field.

Set the signed flag in fields we decode that should be signed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65507
Build 62390: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 17 2025, 11:32 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 17 2025, 11:32 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jul 17 2025, 11:32 AM

Harbormaster completed remote builds in B65507: Diff 158658.Jul 17 2025, 11:32 AM

andrew added a child revision: D51370: arm64: Rename ID_AA64MMFR0_ECV_CNTHCTL.Jul 17 2025, 11:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2025, 12:11 PM

Closed by commit rG118bfc9f53ac: arm64: Fix the sign in ID registers (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG118bfc9f53ac: arm64: Fix the sign in ID registers.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

identcpu.c

11 lines

Diff 158658

View Options

sys/arm64/arm64/identcpu.c

arm64: Fix the sign in ID registersClosedPublicActions