i386: Avoid calling kmem_alloc_contig(M_NEVERFREED)
ClosedPublic
Actions

Authored by markj on Mon, Jul 14, 7:40 PM.

Details

Reviewers

alc
kib

Commits

rGc8a523690b1a: i386: Avoid calling kmem_alloc_contig(M_NEVERFREED)

Summary

vm_page_alloc_contig* don't handle VM_ALLOC_NOFREE. After commit
07297aee35f2 ("vm_page: update comments and KASSERT()s concerning page allocation"),
pmap_pdpt_allocf() triggers one of the added assertions, since pdptzone
is a NOFREE zone.

Simply clear the flag when allocating a slab. It is not worth trying to
implement support for the NOFREE allocator here.

Reported by: Jenkins

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jul 14, 7:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 14, 7:40 PM

markj requested review of this revision.Mon, Jul 14, 7:40 PM

Harbormaster completed remote builds in B65429: Diff 158495.Mon, Jul 14, 7:40 PM

emaste added a subscriber: emaste.Mon, Jul 14, 7:51 PM

kib accepted this revision.Mon, Jul 14, 9:07 PM

This revision is now accepted and ready to land.Mon, Jul 14, 9:07 PM

alc accepted this revision.Tue, Jul 15, 12:17 AM

Closed by commit rGc8a523690b1a: i386: Avoid calling kmem_alloc_contig(M_NEVERFREED) (authored by markj). · Explain WhyTue, Jul 15, 12:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc8a523690b1a: i386: Avoid calling kmem_alloc_contig(M_NEVERFREED).

Revision Contents
Changeset List

Path

Size

sys/

i386/

pmap.c

10 lines

Diff 158539

View Options

i386: Avoid calling kmem_alloc_contig(M_NEVERFREED)ClosedPublicActions