generate-ucl.sh: use correct exit status
ClosedPublic
Actions

Authored by ivy on Jul 7 2025, 2:14 PM.

Details

Reviewers

des
kevans

Group Reviewers

pkgbase

Commits

rG953b3a061438: release/packages/generate-ucl.sh: use correct exit status

Summary

Propagate the exit status from generate-ucl.lua, so that if parsing
the UCL fails, the package generation step also fails.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65254
Build 62137: arc lint + arc unit

Event Timeline

ivy created this revision.Jul 7 2025, 2:14 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptJul 7 2025, 2:14 PM

ivy requested review of this revision.Jul 7 2025, 2:14 PM

Harbormaster completed remote builds in B65254: Diff 158099.Jul 7 2025, 2:14 PM

ivy added a parent revision: D50284: packages: handle suffixes in generate-ucl.lua.Jul 7 2025, 3:11 PM

des added inline comments.Jul 7 2025, 3:37 PM

release/packages/generate-ucl.sh
93	Simply dropping this line (and the blank line that precedes it) has the same effect.

do it this way instead

Harbormaster completed remote builds in B65255: Diff 158106.Jul 7 2025, 3:39 PM

kevans accepted this revision as: kevans.Jul 15 2025, 5:03 AM

This revision is now accepted and ready to land.Jul 15 2025, 5:03 AM

Closed by commit rG953b3a061438: release/packages/generate-ucl.sh: use correct exit status (authored by ivy). · Explain WhyJul 15 2025, 5:13 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG953b3a061438: release/packages/generate-ucl.sh: use correct exit status.

Revision Contents
Changeset List

Path

Size

release/

packages/

generate-ucl.sh

2 lines

Diff 158099

View Options

release/packages/generate-ucl.sh

release/packages/generate-ucl.sh: use correct exit statusClosedPublicActions