Page MenuHomeFreeBSD
Differential D51180

amd64 pmap: convert some panics to KASSERTs
ClosedPublic
Actions

Authored by alc on Sun, Jul 6, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 16, 9:15 AM
Unknown Object (File)
Mon, Jul 7, 12:06 AM
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs
Summary

With the recent changes to pmap_demote_DMAP(), the calls to pmap_demote_pdpe() and pmap_demote_pde_mpte() should never fail.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc requested review of this revision.Sun, Jul 6, 5:53 PM
alc created this revision.
kib accepted this revision.Sun, Jul 6, 5:58 PM
This revision is now accepted and ready to land.Sun, Jul 6, 5:58 PM
kib added a comment.Sun, Jul 6, 6:09 PM

Should the pmap_demote_pde() in pmap_unwire() get the same treatment? As I understand, wire should saved the pt page in radix.

markj accepted this revision.Sun, Jul 6, 6:40 PM
alc added a comment.Sun, Jul 6, 8:16 PM
In D51180#1168328, @kib wrote:

Should the pmap_demote_pde() in pmap_unwire() get the same treatment? As I understand, wire should saved the pt page in radix.

I think that should be preceded by the changes under discussion in D49442.

Closed by commit rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs (authored by alc). · Explain WhyMon, Jul 7, 12:07 AM
This revision was automatically updated to reflect the committed changes.
alc added a commit: rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs.
Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 7, 12:07 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
12 lines

Diff 158076

View Options

sys/amd64/amd64/pmap.c

Loading...