LinuxKPI: MODULE_DEVICE_TABLE() factor out the bus specific MODULE_PNP_INFO()
ClosedPublic
Actions

Authored by bz on Jun 25 2025, 8:24 PM.

Details

Reviewers

imp
shurd
dumbbell

Group Reviewers

linuxkpi

Commits

rG87e6f90667e5: LinuxKPI: MODULE_DEVICE_TABLE() factor out the bus specific MODULE_PNP_INFO()
rG2f5666c1727c: LinuxKPI: MODULE_DEVICE_TABLE() factor out the bus specific MODULE_PNP_INFO()

Summary

In order to be able to use MODULE_DEVICE_TABLE() with multiple bus
attachments, factor out the bus-specfic MODULE_PNP_INFO() and place
it next to the structure defining the table.

As it turns out bnxt(4) has been using the MODULE_DEVICE_TABLE() with
PCI attachments for the "auxillary" bus so far. That makes little sense.
Define the MODULE_PNP_INFO() to nothing for that. We may consider
pulling these LinucKPI bits in semi-native drivers into LinuxKPI
one day as that route is not really sustainabke.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jun 25 2025, 8:24 PM

Herald added a reviewer: shurd. · View Herald TranscriptJun 25 2025, 8:24 PM

Herald added a subscriber: emaste. · View Herald Transcript

bz requested review of this revision.Jun 25 2025, 8:24 PM

Harbormaster completed remote builds in B65089: Diff 157621.Jun 25 2025, 8:24 PM

As is, this change is good. Some notes for the future..

sys/compat/linuxkpi/common/include/linux/pci.h
80	This macro is now out of place in pci.h. It's likely fine for now, but we'll need to move it so usb drivers, say, don't need to include pci.h to get the definition for MODULE_DEVICE_TABLE.... Assuming Linux has a generic interface for that.

This revision is now accepted and ready to land.Jun 25 2025, 8:42 PM

bz marked an inline comment as done.Jun 25 2025, 8:46 PM

bz added inline comments.