Page MenuHomeFreeBSD
Differential D51119

Revert "src/Makefile: log real/user/system time for build targets"
ClosedPublic
Actions

Authored by brooks on Tue, Jul 1, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 6, 10:13 AM
Unknown Object (File)
Wed, Jul 2, 4:40 PM
Subscribers
imp
markj

Details

Reviewers
wosch
markj
Group Reviewers
srcmgr
Commits
rG1b06e0b889f8: Revert "src/Makefile: log real/user/system time for build targets"
Summary

This broke make makeman by unconditionally adding output to all top
level targets. Lacking an obvious and trivial workaround, it makes
sense to back it out and rethink.

This reverts commit afa70490ee779646fa0e936801cb28795580bf01.

PR: 287274

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Tue, Jul 1, 11:01 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 1, 11:01 PM
Harbormaster completed remote builds in B65166: Diff 157811.Tue, Jul 1, 11:01 PM
brooks requested review of this revision.Tue, Jul 1, 11:01 PM
wosch added a comment.Wed, Jul 2, 7:51 AM

I never heard of `make makeman', it is not documented in build(7). I can take care only of known targets.

It seems that tools/build/options/makeman calls make showconfig' dozend times and parse the output. I get the part where someone wants to parse the output of make sometarget' for whatever reasons. I think the workaround is to display the time log to stderr instead stdout

e.g.
echo "Time spent....." >&2

and maybe make the output optional (similar to TIME_ENV)

markj accepted this revision as: markj.Wed, Jul 2, 12:50 PM
markj added a subscriber: markj.

I think it's fine to revert for now while a solution is worked out.

In D51119#1166809, @wosch wrote:

I never heard of `make makeman', it is not documented in build(7). I can take care only of known targets.

It seems that tools/build/options/makeman calls make showconfig' dozend times and parse the output. I get the part where someone wants to parse the output of make sometarget' for whatever reasons. I think the workaround is to display the time log to stderr instead stdout

e.g.
echo "Time spent....." >&2

and maybe make the output optional (similar to TIME_ENV)

Or just disable this feature for certain targets where it doesn't make a lot of sense, at least for showconfig, buildenv, buildenvvars?

This revision is now accepted and ready to land.Wed, Jul 2, 12:50 PM
wosch added a comment.Wed, Jul 2, 1:51 PM

For the proposed workaround "write time logging to stderr instead of stdout" see

https://reviews.freebsd.org/D51129

markj mentioned this in D51129: src/Makefile: write time logging to stderr instead of stdout.Wed, Jul 2, 1:51 PM
Closed by commit rG1b06e0b889f8: Revert "src/Makefile: log real/user/system time for build targets" (authored by brooks). · Explain WhyWed, Jul 2, 4:40 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG1b06e0b889f8: Revert "src/Makefile: log real/user/system time for build targets".

Revision Contents
Changeset List

PathSize
11 lines

Diff 157853

View Options

Makefile

Loading...