Page MenuHomeFreeBSD

git-arc: Try harder to get the author name and email out of phab
ClosedPublic

Authored by markj on Thu, Jun 26, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 6, 4:30 AM
Unknown Object (File)
Sat, Jul 5, 7:47 PM
Unknown Object (File)
Sat, Jul 5, 6:08 AM
Unknown Object (File)
Wed, Jul 2, 2:37 PM
Unknown Object (File)
Thu, Jun 26, 5:36 PM
Subscribers

Details

Summary

When patching, we use the querydiffs endpoint to get a name and email
for the revision's author. It's possible that this info isn't recorded,
in which case the results after post-processing are just "null".
However, if the diff has multiple revisions, the endpoint returns an
entry for each one, some of which may contain author info, others not.
So, the deleted code which tries to filter out "null" isn't sufficient,
since the value in question might be something like "<valid
name>\nnull".

Try to make this filtering a bit smarter.

Reported by: des

Test Plan

git arc patch -c D46547 (with commit 0804e60df19b393c37238596c9f37a0b8972a7da reverted)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Thu, Jun 26, 2:17 PM
markj edited the test plan for this revision. (Show Details)

This is better than what we currently have. I'm only worried for "Annulla" and "Annullius" :)

This revision is now accepted and ready to land.Thu, Jun 26, 5:53 PM
tools/tools/git/git-arc.sh
587

Yes, on a second thought, what about ... grep -v "^null$" .... Annullio is unlikely, but nullbyte.io, or alike, are very possible

Be more careful about matching null entries.

This revision now requires review to proceed.Fri, Jun 27, 12:11 AM
markj added inline comments.
tools/tools/git/git-arc.sh
587

Indeed, thank you.

This revision is now accepted and ready to land.Fri, Jun 27, 12:16 AM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.