Page MenuHomeFreeBSD
Differential D51115

authors: add SHENGYI HUNG as a committerr
ClosedPublic
Actions

Authored by aokblast on Tue, Jul 1, 3:43 PM.
Tags
None
Referenced Files
F124375218: D51115.diff
Fri, Jul 25, 8:13 PM
Unknown Object (File)
Wed, Jul 23, 2:41 PM
Unknown Object (File)
Tue, Jul 22, 2:31 AM
Unknown Object (File)
Fri, Jul 18, 7:35 PM
Subscribers
khng

Details

Reviewers
lwhsu
markj
Commits
R9:8d6dcda3ef8e: new comitter (src): ShengYi Hung (aokblast)

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 65159
Build 62042: arc lint + arc unit

Event Timeline

aokblast requested review of this revision.Tue, Jul 1, 3:43 PM
aokblast created this revision.
Harbormaster completed remote builds in B65159: Diff 157798.Tue, Jul 1, 3:43 PM
aokblast added reviewers: lwhsu, markj.Tue, Jul 1, 3:46 PM
markj accepted this revision.Tue, Jul 1, 4:07 PM

Approved

This revision is now accepted and ready to land.Tue, Jul 1, 4:07 PM
lwhsu requested changes to this revision.Wed, Jul 2, 4:29 AM
lwhsu added inline comments.
shared/authors.adoc
3768

Please add to the position sorted by the login.

shared/contrib-committers.adoc
404

This part is tricky, traditionally we sort this by the last name (so you need to find a place for "Hong"). It seems some previous addition didn't know this convention...

You can check the account's full name on web page or using finger command on freefall.

website/data/en/news/news.toml
5

Would be nice to keep upper/lower case sync across all the place.

This revision now requires changes to proceed.Wed, Jul 2, 4:29 AM
lwhsu added a subscriber: khng.Wed, Jul 2, 4:30 AM
aokblast updated this revision to Diff 157814.Wed, Jul 2, 4:37 AM

fix all

Harbormaster completed remote builds in B65169: Diff 157814.Wed, Jul 2, 4:38 AM
aokblast added inline comments.Wed, Jul 2, 4:40 AM
shared/contrib-committers.adoc
404

It is a little bit hard to track because the original list is unsorted. If I want to insert it into the correct location, I needs to change lots of entry.

lwhsu added inline comments.Wed, Jul 2, 4:43 AM
shared/contrib-committers.adoc
404

ok, I think this needs another fix, we can work with doc team later.

aokblast updated this revision to Diff 157815.Wed, Jul 2, 4:48 AM

Use same naming convention as LDAP

Harbormaster completed remote builds in B65170: Diff 157815.Wed, Jul 2, 4:48 AM
lwhsu accepted this revision.Wed, Jul 2, 5:03 AM
This revision is now accepted and ready to land.Wed, Jul 2, 5:03 AM
Closed by commit R9:8d6dcda3ef8e: new comitter (src): ShengYi Hung (aokblast) (authored by aokblast). · Explain WhyWed, Jul 2, 1:47 PM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: R9:8d6dcda3ef8e: new comitter (src): ShengYi Hung (aokblast).

Revision Contents
Changeset List

PathSize
documentation/
static/
pgpkeys/
55 lines
shared/
4 lines
1 line
website/
data/
en/
news/
4 lines

Diff 157798

View Options

documentation/static/pgpkeys/aokblast.key

Loading...
View Options

shared/authors.adoc

Loading...
View Options

shared/contrib-committers.adoc

Loading...
View Options

website/data/en/news/news.toml

Loading...