cp: Add an option to visit sources in order.
AcceptedPublic
Actions

Authored by des on Tue, Jul 1, 9:06 AM.

Details

Reviewers

kevans

Group Reviewers

Klara

Summary

This adds a --sort option which makes cp pass a comparison function to
FTS, ensuring that sources are visited and traversed in a predictable
order. This will help make certain test cases more reliable.

While here, add GNU-compatible long options where appropriate, fully
switch boolean variables from int to bool, and clean up the manual page
a little.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65143
Build 62026: arc lint + arc unit

Event Timeline

des created this revision.Tue, Jul 1, 9:06 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Jul 1, 9:06 AM

des requested review of this revision.Tue, Jul 1, 9:06 AM

Harbormaster completed remote builds in B65143: Diff 157775.Tue, Jul 1, 9:06 AM

des added a parent revision: D51096: cp: Don't rely on FTS_DP to keep track of depth..Tue, Jul 1, 9:06 AM

I think I'd prefer to add a --stable long option to avoid a collision with coreutils' cp -S; I don't think there's any technical reason we *wouldn't* implement backup files.

In D51100#1166649, @kevans wrote:

I think I'd prefer to add a --stable long option [...]

We don't currently support long options at all in cp...

In D51100#1166709, @des wrote:

In D51100#1166649, @kevans wrote:

I think I'd prefer to add a --stable long option [...]

We don't currently support long options at all in cp...

Sure, but they're not exactly complicated to add and we can follow-up later to add other comptible long options to be nice. getopt_long is nearly a drop-in replacement if you mutate the optstring right.