Page MenuHomeFreeBSD

mkimg: Make output reproducible using a specific timestamp
ClosedPublic

Authored by markj on Fri, Jun 27, 6:26 PM.
Tags
None
Referenced Files
F124074273: D51077.id157711.diff
Tue, Jul 22, 6:55 AM
F124062627: D51077.diff
Tue, Jul 22, 3:33 AM
Unknown Object (File)
Thu, Jul 10, 2:57 PM
Unknown Object (File)
Thu, Jul 10, 4:29 AM
Unknown Object (File)
Mon, Jul 7, 8:29 PM
Unknown Object (File)
Sat, Jul 5, 1:03 PM
Unknown Object (File)
Sat, Jul 5, 6:15 AM
Unknown Object (File)
Thu, Jul 3, 1:05 AM
Subscribers

Details

Summary

In commit 95ac5b0e27e9 ("mkimg: Add a reproducible mode"), I added a -R
flag to mkimg, indicating that output should be reproducible.

There is one place in the VHD image backend that uses time(3) to
populate an image metadata field; this field is visible to tools which
know how to process VHD images. Rather than picking an arbitrary value
for that timestamp, it seems better to behave like makefs(8) and let the
invoker pick a suitable timestamp.

So, remove -R and instead add a -t option which lets the timestamp be
specified directly. Then, modify the VHD backend to use that timestamp.

Fixes: 95ac5b0e27e9 ("mkimg: Add a reproducible mode")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65122
Build 62005: arc lint + arc unit