Page MenuHomeFreeBSD
Differential D51026

lockf: tests: add tests for the -p and -T features
ClosedPublic
Actions

Authored by kevans on Tue, Jun 24, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 10, 7:17 PM
Unknown Object (File)
Mon, Jul 7, 9:32 AM
Unknown Object (File)
Mon, Jul 7, 8:05 AM
Unknown Object (File)
Sun, Jul 6, 8:12 PM
Unknown Object (File)
Sun, Jul 6, 4:43 AM
Unknown Object (File)
Wed, Jul 2, 3:18 AM
Unknown Object (File)
Fri, Jun 27, 11:27 PM
Subscribers
imp

Details

Reviewers
allanjude
des
Commits
rGc82203e65d08: lockf: tests: add tests for the -p and -T features

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65066
Build 61949: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Jun 24, 11:19 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 24, 11:19 PM
kevans requested review of this revision.Tue, Jun 24, 11:19 PM
Harbormaster completed remote builds in B65066: Diff 157556.Tue, Jun 24, 11:19 PM
kevans added a parent revision: D51025: lockf: add a -T option to terminate the child upon early abort.Tue, Jun 24, 11:19 PM
kevans added a child revision: D51027: lockf: minor cosmetic cleanups, no functional change.Tue, Jun 24, 11:21 PM
des requested changes to this revision.Tue, Jul 1, 10:50 AM
des added inline comments.
usr.bin/lockf/tests/lockf_test.sh
229
230
250
251
295

what's the point of capturing stdout here?

296

what's the point of capturing stdout here?

311
This revision now requires changes to proceed.Tue, Jul 1, 10:50 AM
kevans marked an inline comment as done.Tue, Jul 1, 12:55 PM
kevans added inline comments.
usr.bin/lockf/tests/lockf_test.sh
295

save captures, file checks. these are both ensuring that we're only getting back the single pid.

des added inline comments.Tue, Jul 1, 1:36 PM
usr.bin/lockf/tests/lockf_test.sh
295

oh, I misread

kevans updated this revision to Diff 158018.Sat, Jul 5, 5:00 PM
kevans marked 6 inline comments as done.

Address typos and other review feedback

Harbormaster completed remote builds in B65225: Diff 158018.Sat, Jul 5, 5:00 PM
des accepted this revision.Thu, Jul 10, 4:44 PM

only nits left

usr.bin/lockf/tests/lockf_test.sh
37

consider making this (and cur and tmo) local

This revision is now accepted and ready to land.Thu, Jul 10, 4:44 PM
des added inline comments.Thu, Jul 10, 4:45 PM
usr.bin/lockf/tests/lockf_test.sh
36

phab won't let me post this edit suggestion without a comment 🙄

288

phab won't let me post this edit suggestion without a comment 🙄

kevans marked 3 inline comments as done.Thu, Jul 10, 5:52 PM
Closed by commit rGc82203e65d08: lockf: tests: add tests for the -p and -T features (authored by kevans). · Explain WhyThu, Jul 10, 5:55 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGc82203e65d08: lockf: tests: add tests for the -p and -T features.

Revision Contents
Changeset List

PathSize
usr.bin/
lockf/
tests/
95 lines

Diff 157556

View Options

usr.bin/lockf/tests/lockf_test.sh

Loading...