lockf: tests: add tests for the -p and -T features
Needs ReviewPublic
Actions

Authored by kevans on Tue, Jun 24, 11:19 PM.

Details

Reviewers

allanjude
des

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65066
Build 61949: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Jun 24, 11:19 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 24, 11:19 PM

kevans requested review of this revision.Tue, Jun 24, 11:19 PM

Harbormaster completed remote builds in B65066: Diff 157556.Tue, Jun 24, 11:19 PM

kevans added a parent revision: D51025: lockf: add a -T option to terminate the child upon early abort.Tue, Jun 24, 11:19 PM

kevans added a child revision: D51027: lockf: minor cosmetic cleanups, no functional change.Tue, Jun 24, 11:21 PM

des requested changes to this revision.Tue, Jul 1, 10:50 AM

des added inline comments.

usr.bin/lockf/tests/lockf_test.sh
229
230
250
251
295	what's the point of capturing stdout here?
296	what's the point of capturing stdout here?
311

This revision now requires changes to proceed.Tue, Jul 1, 10:50 AM

kevans marked an inline comment as done.Tue, Jul 1, 12:55 PM

kevans added inline comments.

usr.bin/lockf/tests/lockf_test.sh
295	save captures, file checks. these are both ensuring that we're only getting back the single pid.

des added inline comments.Tue, Jul 1, 1:36 PM

usr.bin/lockf/tests/lockf_test.sh
295	oh, I misread

Address typos and other review feedback

Harbormaster completed remote builds in B65225: Diff 158018.Sat, Jul 5, 5:00 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

lockf/

tests/

lockf_test.sh

95 lines

Diff 157556

View Options

usr.bin/lockf/tests/lockf_test.sh

lockf: tests: add tests for the -p and -T featuresNeeds ReviewPublicActions