qlnx: fix panic at startup
ClosedPublic
Actions

Authored by kp on Thu, Jun 12, 4:59 PM.

Details

Reviewers

markj
zlei

Group Reviewers

network
pfsense

Commits

rG4f7473d18a62: qlnx: fix panic at startup

Summary

While attaching the qlnx driver we can end up trying to call ifmedia functions
before those are set up (through ether_ifattach() -> rtnl_handle_ifattach()
-> dump_iface() -> get_operstate_ether() -> ifmedia_ioctl()). Postpone the
ether_ifattach() until after the ifmedia setup.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64821
Build 61704: arc lint + arc unit

Event Timeline

kp created this revision.Thu, Jun 12, 4:59 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 12, 4:59 PM

kp requested review of this revision.Thu, Jun 12, 4:59 PM

Harbormaster completed remote builds in B64821: Diff 156922.Thu, Jun 12, 5:00 PM

markj accepted this revision as: markj.Thu, Jun 12, 8:02 PM

This revision is now accepted and ready to land.Thu, Jun 12, 8:02 PM

zlei accepted this revision as: zlei.Fri, Jun 13, 3:29 AM

zlei added a subscriber: zlei.

zlei added inline comments.

sys/dev/qlnx/qlnxe/qlnx_os.c
2366	Indeed `ether_ifattach()` will override `if_hdrlen`, but I think that is probably wrong design and have WIP fix for that. There're lots of drivers set `if_hdrlen` after `ether_ifattach()` and I'll fix them all individually.