Page MenuHomeFreeBSD

libc, libthr: Ditch MD __pthread_distribute_static_tls helpers
ClosedPublic

Authored by jrtc27 on May 28 2025, 10:42 PM.
Tags
None
Referenced Files
F170106995: D50592.id156240.diff
Thu, Sep 3, 1:02 PM
F170061153: D50592.diff
Thu, Sep 3, 9:53 AM
Unknown Object (File)
Wed, Sep 2, 6:35 PM
Unknown Object (File)
Wed, Sep 2, 11:11 AM
Unknown Object (File)
Tue, Sep 1, 12:16 PM
Unknown Object (File)
Tue, Sep 1, 10:06 AM
Unknown Object (File)
Tue, Sep 1, 10:03 AM
Unknown Object (File)
Mon, Aug 31, 2:35 PM
Subscribers

Details

Summary

_libc_get_static_tls_base() is just _tcb_get() followed by adding (for
Variant I) or subtracting (for Variant II) the offset, so just inline
that as the implementation (like we do in rtld-elf) rather than having
another copy (or equivalent) of _tcb_get()'s assembly.

_get_static_tls_base() doesn't even have any MD assembly as it's
reading thr->tcb, the only difference is whether to add or subtract, so
again just inline that.

Whilst here add some missing blank lines to comply with style(9) for
elf_utils.c's includes, and use a pointer type rather than uintptr_t to
reduce the need to cast, as is done in rtld-elf.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable